[GitHub] [airflow] ashb commented on a change in pull request #12630: Allow to configure Flower's url_prefix

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #12630:
URL: https://github.com/apache/airflow/pull/12630#discussion_r551379989



##########
File path: chart/templates/flower/flower-deployment.yaml
##########
@@ -111,6 +111,10 @@ spec:
                   name: {{ template "flower_secret" . }}
                   key: basicAuth
             {{- end }}
+            {{- if .Values.flower.url_prefix }}
+            - name: FLOWER_URL_PREFIX
+              value: {{.Values.flower.url_prefix }}
+            {{- end }}

Review comment:
       Ah.
   
   Instead of adding a new setting for this, we should
   ```suggestion
               {{- include "custom_airflow_environment" . | indent 10 }}
   ```
   
   Then the existing environment variable would work. Right now without any changes this can be set in the airflow.cfg config map.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org