[jira] [Comment Edited] (VALIDATOR-336) CUSIPCheckDigit Thinks Invalid CUSIP is Valid

["Benedikt Ritter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VALIDATOR-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206777#comment-14206777 ] 

Benedikt Ritter edited comment on VALIDATOR-336 at 11/11/14 6:36 PM:
---------------------------------------------------------------------

Hello again,

I've tried to incorporate the changes from CusipValidatorTest_v2.java into the CUSIPCheckDigitTest (see VALIDATOR-336.patch). Although the code {{DUS0421CW}} is invalid, the calculate method doesn't throw an exception for it (hence the test fails). Can you check once again? ;-)

Regarding the general style of patches: Please include Apache License Headers if you add new files and use spaces for indentation (not tabs).

TIA!
Benedikt


was (Author: britter):
Hello again,

I've tried to incorporate the changes from CusipValidatorTest_v2.java into the CUSIPCheckDigitTest. Although the code {{DUS0421CW}} is invalid, the calculate method doesn't throw an exception for it (hence the test fails). Can you check once again? ;-)

Regarding the general style of patches: Please include Apache License Headers if you add new files and use spaces for indentation (not tabs).

TIA!
Benedikt

> CUSIPCheckDigit Thinks Invalid CUSIP is Valid
> ---------------------------------------------
>
>                 Key: VALIDATOR-336
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-336
>             Project: Commons Validator
>          Issue Type: Bug
>            Reporter: Josh Meyer
>         Attachments: CUSIPCheckDigit.java.patch, CusipValidatorTest.java, CusipValidatorTest_v2.java, VALIDATOR-336.patch
>
>
> When testing if a specific CUSIP is valid using org.apache.commons.validator.routines.checkdigit.CUSIPCheckDigit.CUSIP_CHECK_DIGIT.isValid, a call to this returns true when it should return false. A specific example is with the following invalid CUSIP: DUS0421CW.
> What seems to be happening is when toInt is called on W it turns it to an int value and then sends it to weightedValue. This is fine for the first 8 characters of a CUSIP, but not the check digit. The expected result should be to return false because the check digit is a letter (on a CUSIP a check digit must be 0-9). 
> With the current implementation, I believe each CUSIP can have up to 4 valid check digits.
> A test is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)