You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/06/29 11:06:38 UTC
[GitHub] [incubator-ratis] runzhiwang opened a new pull request #138: RATIS-989. Avoid change state from closing to exception in LogAppender
runzhiwang opened a new pull request #138:
URL: https://github.com/apache/incubator-ratis/pull/138
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## What is the link to the Apache JIRA
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. RATIS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] lokeshj1703 closed pull request #138: RATIS-989. Avoid change state from CLOSING to EXCEPTION in LogAppender
Posted by GitBox <gi...@apache.org>.
lokeshj1703 closed pull request #138:
URL: https://github.com/apache/incubator-ratis/pull/138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #138: RATIS-989. Avoid change state from closing to exception in LogAppender
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #138:
URL: https://github.com/apache/incubator-ratis/pull/138#issuecomment-651043751
@lokeshj1703 Could you help review this patch ? Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] lokeshj1703 commented on pull request #138: RATIS-989. Avoid change state from CLOSING to EXCEPTION in LogAppender
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #138:
URL: https://github.com/apache/incubator-ratis/pull/138#issuecomment-651714855
@runzhiwang Thanks for the contribution! I have committed the PR to master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on a change in pull request #138: RATIS-989. Avoid change state from closing to exception in LogAppender
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on a change in pull request #138:
URL: https://github.com/apache/incubator-ratis/pull/138#discussion_r447560825
##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/LogAppender.java
##########
@@ -117,6 +121,16 @@ void stop() {
public String toString() {
return name;
}
+
+ private boolean transLifeCycle(LifeCycle.State to) {
Review comment:
@lokeshj1703 Thanks for review. I have updated it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] lokeshj1703 commented on a change in pull request #138: RATIS-989. Avoid change state from closing to exception in LogAppender
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on a change in pull request #138:
URL: https://github.com/apache/incubator-ratis/pull/138#discussion_r447545765
##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/LogAppender.java
##########
@@ -117,6 +121,16 @@ void stop() {
public String toString() {
return name;
}
+
+ private boolean transLifeCycle(LifeCycle.State to) {
Review comment:
NIT: Lets rename it to transitionLifeCycle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #138: RATIS-989. Avoid change state from closing to exception in LogAppender
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #138:
URL: https://github.com/apache/incubator-ratis/pull/138#issuecomment-651044218
CI can not be triggered, We should wait for CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang removed a comment on pull request #138: RATIS-989. Avoid change state from closing to exception in LogAppender
Posted by GitBox <gi...@apache.org>.
runzhiwang removed a comment on pull request #138:
URL: https://github.com/apache/incubator-ratis/pull/138#issuecomment-651044218
CI can not be triggered, We should wait for CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org