You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Mesos ReviewBot <de...@mesos.apache.org> on 2014/12/26 20:07:46 UTC
Re: Review Request 29437: Bug fix: Start the executor registration
timer, only when the container has launched successfully
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29437/#review66170
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29437]
All tests passed.
- Mesos ReviewBot
On Dec. 26, 2014, 6:29 p.m., Nishant Suneja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29437/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2014, 6:29 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-999
> https://issues.apache.org/jira/browse/MESOS-999
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> As part of this bug fix, I have trigerred the executor registration timeout timer asychronously,
> when the onReady() callback is made for the container's future object, instead of starting the
> timer synchronously when the launchExecutor() method of the Framework class is invoked.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
>
> Diff: https://reviews.apache.org/r/29437/diff/
>
>
> Testing
> -------
>
> make check succeeds.
>
>
> Thanks,
>
> Nishant Suneja
>
>