[GitHub] [celix] abroekhuis commented on a change in pull request #282: Hotfix/rsa deadlock

[GitBox <gi...@apache.org>]

abroekhuis commented on a change in pull request #282:
URL: https://github.com/apache/celix/pull/282#discussion_r486522675



##########
File path: bundles/remote_services/remote_service_admin_dfi/src/export_registration_dfi.c
##########
@@ -86,6 +86,7 @@ celix_status_t exportRegistration_create(celix_log_helper_t *helper, service_ref
         reg->logFile = logFile;
         reg->servId = strndup(servId, 1024);
         reg->trackerId = -1L;
+        reg->active = true;

Review comment:
       Not sure if it is relevant at this point, but the function setActive uses a lock, is that needed here as well?

##########
File path: bundles/remote_services/remote_service_admin_dfi/src/remote_service_admin_dfi.c
##########
@@ -56,13 +57,30 @@
 #define RSA_LOG_DEBUG(admin, msg, ...) \
     celix_logHelper_log((admin)->loghelper, CELIX_LOG_LEVEL_ERROR, (msg),  ##__VA_ARGS__)
 
+
+/**
+ * If set to true the rsa will create a thread to handle stopping of service export.
+ *
+ * This stop thread can be removed when the branch feature/async_svc_registration is merged and
+ * celix_bundleContext_stopTrackerAsync is available.
+ *
+ */
+#define CELIX_RSA_USE_STOP_EXPORT_THREAD true

Review comment:
       Why a define, and not a property of the bundle?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org