You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by amyrazz44 <gi...@git.apache.org> on 2016/11/16 03:07:30 UTC
[GitHub] incubator-hawq pull request #1014: HAWQ-858. Fix parser to understand case /...
GitHub user amyrazz44 opened a pull request:
https://github.com/apache/incubator-hawq/pull/1014
HAWQ-858. Fix parser to understand case / when expression in group by
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amyrazz44/incubator-hawq parserTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1014.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1014
----
commit d5efb6be4508f13c9f238fc53a31cc1a800044a5
Author: amyrazz44 <ab...@pivotal.io>
Date: 2016-11-15T07:43:38Z
HAWQ-858. Fix parser to understand case / when expression in group by
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1014: HAWQ-858. Fix parser to understand case /...
Posted by amyrazz44 <gi...@git.apache.org>.
Github user amyrazz44 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1014
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1014: HAWQ-858. Fix parser to understand case / when e...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/1014
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1014: HAWQ-858. Fix parser to understand case / when e...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1014
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1014: HAWQ-858. Fix parser to understand case /...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1014#discussion_r91225027
--- Diff: src/test/feature/query/test_parser.cpp ---
@@ -0,0 +1,34 @@
+#include <pwd.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <vector>
+#include <stdio.h>
+#include <stdlib.h>
+#include <errno.h>
+#include <iostream>
+#include <string>
+
+#include "lib/sql_util.h"
+
+#include "gtest/gtest.h"
+
+class TestParser : public ::testing::Test {
+ public:
+ TestParser() {}
+ ~TestParser() {}
+};
+
+
+TEST_F(TestParser, TestParserCaseGroupBy) {
+ hawq::test::SQLUtility util;
+ // prepare
+ util.execute("DROP TABLE IF EXISTS mytable CASCADE");
+ util.execute("CREATE TABLE mytable (a int, b int, c varchar(1))");
+ // test
+ util.execSQLFile("query/sql/parser-casegroupby.sql",
+ "query/ans/parser-casegroupby.ans");
+ // cleanup
+ util.execute("DROP TABLE mytable CASCADE");
+ util.execute("DROP FUNCTION negate(int)");
+}
--- End diff --
The comment seems to be not needed since they are quite straightforward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1014: HAWQ-858. Fix parser to understand case / when e...
Posted by amyrazz44 <gi...@git.apache.org>.
Github user amyrazz44 commented on the issue:
https://github.com/apache/incubator-hawq/pull/1014
@huor @paul-guo- Please review the pull request . Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1014: HAWQ-858. Fix parser to understand case /...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1014#discussion_r91225067
--- Diff: src/test/feature/query/test_parser.cpp ---
@@ -0,0 +1,34 @@
+#include <pwd.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <vector>
+#include <stdio.h>
+#include <stdlib.h>
+#include <errno.h>
+#include <iostream>
+#include <string>
+
--- End diff --
I suspect many of those included files are not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1014: HAWQ-858. Fix parser to understand case /...
Posted by amyrazz44 <gi...@git.apache.org>.
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1014#discussion_r91430078
--- Diff: src/test/feature/query/test_parser.cpp ---
@@ -0,0 +1,34 @@
+#include <pwd.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <vector>
+#include <stdio.h>
+#include <stdlib.h>
+#include <errno.h>
+#include <iostream>
+#include <string>
+
--- End diff --
Will test this, thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1014: HAWQ-858. Fix parser to understand case / when e...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1014
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---