You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/05/01 02:11:57 UTC

Review Request 33740: Handle UpdateConfigError when starting a job update.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33740/
-----------------------------------------------------------

Review request for Aurora and Zameer Manji.


Bugs: AURORA-1299
    https://issues.apache.org/jira/browse/AURORA-1299


Repository: aurora


Description
-------

Handle UpdateConfigError when starting a job update.


Diffs
-----

  src/main/python/apache/aurora/client/cli/update.py 9f190a62e9bc14f20dbcf7e49917eeb412d2e68a 
  src/test/python/apache/aurora/client/cli/test_supdate.py ccbcae64e894c2ae5fd6a97b1e3dadbb54fbb7d6 

Diff: https://reviews.apache.org/r/33740/diff/


Testing
-------

Test suite, also verified in vagrant:
```
$ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora
Error executing command: Pulse interval seconds must be at least 60 seconds.
```


Thanks,

Bill Farner


Re: Review Request 33740: Handle UpdateConfigError when starting a job update.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33740/#review82232
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On April 30, 2015, 5:11 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33740/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 5:11 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1299
>     https://issues.apache.org/jira/browse/AURORA-1299
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Handle UpdateConfigError when starting a job update.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 9f190a62e9bc14f20dbcf7e49917eeb412d2e68a 
>   src/test/python/apache/aurora/client/cli/test_supdate.py ccbcae64e894c2ae5fd6a97b1e3dadbb54fbb7d6 
> 
> Diff: https://reviews.apache.org/r/33740/diff/
> 
> 
> Testing
> -------
> 
> Test suite, also verified in vagrant:
> ```
> $ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora
> Error executing command: Pulse interval seconds must be at least 60 seconds.
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 33740: Handle UpdateConfigError when starting a job update.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33740/#review82229
-----------------------------------------------------------

Ship it!


Master (f9b60c6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On May 1, 2015, 12:11 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33740/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 12:11 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1299
>     https://issues.apache.org/jira/browse/AURORA-1299
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Handle UpdateConfigError when starting a job update.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 9f190a62e9bc14f20dbcf7e49917eeb412d2e68a 
>   src/test/python/apache/aurora/client/cli/test_supdate.py ccbcae64e894c2ae5fd6a97b1e3dadbb54fbb7d6 
> 
> Diff: https://reviews.apache.org/r/33740/diff/
> 
> 
> Testing
> -------
> 
> Test suite, also verified in vagrant:
> ```
> $ aurora update start devcluster/vagrant/test/http_example /vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora
> Error executing command: Pulse interval seconds must be at least 60 seconds.
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>