You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/29 11:56:46 UTC
[GitHub] [arrow] egillax opened a new pull request, #13990: Arrow-17543: [R] Fix bug for NULL type 0-length vectors in array creation
egillax opened a new pull request, #13990:
URL: https://github.com/apache/arrow/pull/13990
Added the suggested check in ```Array$create()``` from the JIRA issue, that if both the ```x``` and ```type``` are ```NULL``` then the type is manually assigned to ```arrow::null()```.
Added unit tests that captured the bug before I applied the fix and now pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13990: Arrow-17543: [R] Fix bug for NULL type 0-length vectors in array creation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13990:
URL: https://github.com/apache/arrow/pull/13990#issuecomment-1230186679
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13990: ARROW-17543: [R] Fix bug for NULL type 0-length vectors in array creation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13990:
URL: https://github.com/apache/arrow/pull/13990#issuecomment-1230187768
https://issues.apache.org/jira/browse/ARROW-17543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13990: ARROW-17543: [R] Fix bug for NULL type 0-length vectors in array creation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13990:
URL: https://github.com/apache/arrow/pull/13990#issuecomment-1230187797
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] egillax commented on pull request #13990: ARROW-17543: [R] Fix bug for NULL type 0-length vectors in array creation
Posted by GitBox <gi...@apache.org>.
egillax commented on PR #13990:
URL: https://github.com/apache/arrow/pull/13990#issuecomment-1231468732
Hi @thisisnic ,
Thanks for the review. I've updated the tests to use expect_type_equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13990: ARROW-17543: [R] Fix bug for NULL type 0-length vectors in array creation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13990:
URL: https://github.com/apache/arrow/pull/13990#issuecomment-1230187813
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic closed pull request #13990: ARROW-17543: [R] Fix bug for NULL type 0-length vectors in array creation
Posted by GitBox <gi...@apache.org>.
thisisnic closed pull request #13990: ARROW-17543: [R] Fix bug for NULL type 0-length vectors in array creation
URL: https://github.com/apache/arrow/pull/13990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org