You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/09/26 12:09:00 UTC

[jira] [Commented] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements

    [ https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202596#comment-17202596 ] 

ASF subversion and git services commented on OFBIZ-11185:
---------------------------------------------------------

Commit fa86887eb6e90b73df19082236821543e90c8215 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fa86887 ]

Improved: Handle case of partial amount available for return in adjustment in OrderReadHelper.getAvailableOrderHeaderAdjustments method.
(OFBIZ-11185)
Currently it filters all the adjustment that has correspoding returnAdjustment, it should check for amount as well.
Thanks Amit Gadaley for providing the patch.


> OrderReadHelper.getAvailableOrderHeaderAdjustments improvements
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-11185
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11185
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11185.patch
>
>
> We have a helper method in OrderReadHelper named as getAvailableOrderHeaderAdjustments which is used to fetch order header adjustments available for return.
> It should also check for amount, it might possible, orderHeader adjustment was of $100 and once a return is created for $20, then available $80 would not render while creating second return for the same order.
> So instead of checking only for orderAdjustmentId in ReturnAdjustment, it should also check for adjustment amount.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)