You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/10/19 10:52:38 UTC

[GitHub] [myfaces] tandraschko commented on a diff in pull request #338: MYFACES-4477 Fix Programmatic Views

tandraschko commented on code in PR #338:
URL: https://github.com/apache/myfaces/pull/338#discussion_r999278095


##########
impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlTextRendererBase.java:
##########
@@ -142,8 +142,8 @@ protected void renderOutput(FacesContext facesContext, UIComponent component) th
         }
         else
         {
-            //default is to escape
-            escape = AttributeUtils.getBooleanAttribute(component, ComponentAttrs.ESCAPE_ATTR, true);
+            //default is NOT to escape (Changed true -> false, Myfaces-4477)
+            escape = AttributeUtils.getBooleanAttribute(component, ComponentAttrs.ESCAPE_ATTR, false);

Review Comment:
   isnt this a bug security flaw?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org