You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/01 19:13:27 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6356: Minor fix for atexit series function
xiaoxiang781216 opened a new pull request, #6356:
URL: https://github.com/apache/incubator-nuttx/pull/6356
## Summary
- libc: Remove weak_function from __aeabi_atexit
- libc: Always compile ___cxa_atexit
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6356: Minor fix for atexit series function
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6356:
URL: https://github.com/apache/incubator-nuttx/pull/6356#discussion_r887646695
##########
libs/libc/machine/arm/aeabi_atexit.c:
##########
@@ -42,10 +42,8 @@
*
****************************************************************************/
-int weak_function __aeabi_atexit(void *object,
- void (*func)(void *),
- void *dso_handle)
+int __aeabi_atexit(void *object, void (*func)(void *), void *dso_handle)
{
- return atexit_register(ATTYPE_CXA, (void (*)(void))func, object,
+ return atexit_register(ATTYPE_CXA, (CODE void (*)(void))func, object,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6356: Minor fix for atexit series function
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6356:
URL: https://github.com/apache/incubator-nuttx/pull/6356#discussion_r887451617
##########
libs/libc/machine/arm/aeabi_atexit.c:
##########
@@ -42,10 +42,8 @@
*
****************************************************************************/
-int weak_function __aeabi_atexit(void *object,
- void (*func)(void *),
- void *dso_handle)
+int __aeabi_atexit(void *object, void (*func)(void *), void *dso_handle)
{
- return atexit_register(ATTYPE_CXA, (void (*)(void))func, object,
+ return atexit_register(ATTYPE_CXA, (CODE void (*)(void))func, object,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6356: Minor fix for atexit series function
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6356:
URL: https://github.com/apache/incubator-nuttx/pull/6356#discussion_r887241610
##########
libs/libc/machine/arm/aeabi_atexit.c:
##########
@@ -42,10 +42,10 @@
*
****************************************************************************/
-int weak_function __aeabi_atexit(void *object,
- void (*func)(void *),
- void *dso_handle)
+int __aeabi_atexit(FAR void *object,
+ CODE void (*func)(FAR void *),
+ FAR void *dso_handle)
{
- return atexit_register(ATTYPE_CXA, (void (*)(void))func, object,
+ return atexit_register(ATTYPE_CXA, (CODE void (*)(void))func, object,
Review Comment:
Do not need FAR and CODE for ARM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6356: Minor fix for atexit series function
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6356:
URL: https://github.com/apache/incubator-nuttx/pull/6356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6356: Minor fix for atexit series function
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6356:
URL: https://github.com/apache/incubator-nuttx/pull/6356#discussion_r887348957
##########
libs/libc/machine/arm/aeabi_atexit.c:
##########
@@ -42,10 +42,8 @@
*
****************************************************************************/
-int weak_function __aeabi_atexit(void *object,
- void (*func)(void *),
- void *dso_handle)
+int __aeabi_atexit(void *object, void (*func)(void *), void *dso_handle)
{
- return atexit_register(ATTYPE_CXA, (void (*)(void))func, object,
+ return atexit_register(ATTYPE_CXA, (CODE void (*)(void))func, object,
Review Comment:
```suggestion
return atexit_register(ATTYPE_CXA, (void (*)(void))func, object,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6356: Minor fix for atexit series function
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6356:
URL: https://github.com/apache/incubator-nuttx/pull/6356#discussion_r887269867
##########
libs/libc/machine/arm/aeabi_atexit.c:
##########
@@ -42,10 +42,10 @@
*
****************************************************************************/
-int weak_function __aeabi_atexit(void *object,
- void (*func)(void *),
- void *dso_handle)
+int __aeabi_atexit(FAR void *object,
+ CODE void (*func)(FAR void *),
+ FAR void *dso_handle)
{
- return atexit_register(ATTYPE_CXA, (void (*)(void))func, object,
+ return atexit_register(ATTYPE_CXA, (CODE void (*)(void))func, object,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org