[jira] Updated: (LUCENE-573) Escaped quotes inside a phrase cause a ParseException

["Michael Busch (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/LUCENE-573?page=all ]

Michael Busch updated LUCENE-573:
---------------------------------

    Attachment: LUCENE-573_new.patch

I actually found another problem in the current unescaping code:
junit.framework.AssertionFailedError: Query /a\\\+b/ yielded /a\\+b/, expecting /a\+b/

The reason is that the method discardEscapeChar() cannot handle an escaped backslash followed by another escaped character.

I attach a new patch that includes the following:
- the QueryParser unescapes any escaped characters inside a phrase and can handle escaped quotes inside phrases
- for consistency reasons unescaping now is also being done in quoted range queries
- new implementation of discardEscapeChar() that solves the above mentioned problem (escaped backslash followed by another escaped character)
- new tests for TestQueryParser that tests the changes

All unit tests pass.


> Escaped quotes inside a phrase cause a ParseException
> -----------------------------------------------------
>
>                 Key: LUCENE-573
>                 URL: http://issues.apache.org/jira/browse/LUCENE-573
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: QueryParser
>    Affects Versions: 1.9
>         Environment: Debian Sarge, Sun JDK 1.4.2
>            Reporter: Tomislav Gountchev
>         Assigned To: Michael Busch
>            Priority: Minor
>         Attachments: LUCENE-573_new.patch
>
>
> QueryParser cannot handle escaped quotes when inside a phrase. Escaped quotes not in a phrase are not a problem. This can be added to TestQueryParser.testEscaped() to demonstrate the issue - the second assert throws an exception:
> assertQueryEquals("a \\\"b c\\\" d", a, "a \"b c\" d");
> assertQueryEquals("\"a \\\"b c\\\" d\"", a, "\"a \"b c\" d\"");
> See also this thread:
> http://www.nabble.com/ParseException-with-escaped-quotes-in-a-phrase-t1647115.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org