[GitHub] [calcite] vvysotskyi commented on issue #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

[GitBox <gi...@apache.org>]

vvysotskyi commented on issue #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.
URL: https://github.com/apache/calcite/pull/1397#issuecomment-527069650
 
 
   Hi @zabetak, I understand your concerns connected with this change, but I think that it is too unlikely that this change breaks existing clients, since currently if the rule does not have a provided description, it includes `in` and `out` conventions into the description, so it will be broken only for the case when clients used only rules with provided description and convention with illegal name. But even in this case, I think, clients may update the convention name to match the desired pattern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services