[GitHub] [arrow-datafusion] aprimadi commented on a diff in pull request #6706: Move alias generator to per-query execution props

["aprimadi (via GitHub)" <gi...@apache.org>]

aprimadi commented on code in PR #6706:
URL: https://github.com/apache/arrow-datafusion/pull/6706#discussion_r1233099085


##########
datafusion/common/src/lib.rs:
##########
@@ -15,6 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
+pub mod alias;

Review Comment:
   Need suggestion on the best place to put the AliasGenerator code. Currently, I put it in common because it is used in `core`, `optimizer`, and `physical-expr` crate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org