svn commit: r179485 - /spamassassin/trunk/lib/Mail/SpamAssassin/Logger.pm

[jm...@apache.org]

Author: jm
Date: Wed Jun  1 19:02:57 2005
New Revision: 179485

URL: http://svn.apache.org/viewcvs?rev=179485&view=rev
Log:
bug 4379: turn off dubious optimisation, whereby warns/dies with no SA facilities are silently dropped

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/Logger.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Logger.pm
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/lib/Mail/SpamAssassin/Logger.pm?rev=179485&r1=179484&r2=179485&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Logger.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Logger.pm Wed Jun  1 19:02:57 2005
@@ -132,11 +132,13 @@
 sub log_message {
   my ($level, @message) = @_;
 
-  # too many die and warn messages out there, don't log the
-  # ones that we don't own
-  if ($level eq "error" or $level eq "warn") {
-    return unless $message[0] =~ /^\S+:/;
-  }
+  # too many die and warn messages out there, don't log the ones that we don't
+  # own.  jm: off: this makes no sense -- if a dependency module dies or warns,
+  # we want to know about it, unless we're *SURE* it's not something worth
+  # worrying about.
+  # if ($level eq "error" or $level eq "warn") {
+  # return unless $message[0] =~ /^\S+:/;
+  # }
 
   my $message = join(" ", @message);
   $message =~ s/[\r\n]+$//;		# remove any trailing newlines

Re: svn commit: r179485 - /spamassassin/trunk/lib/Mail/SpamAssassin/Logger.pm

[Daniel Quinlan <qu...@pathname.com>]

jm@apache.org writes:

> bug 4379: turn off dubious optimisation, whereby warns/dies with no SA
> facilities are silently dropped

I had that for a good reason -- I think it was the DCC, Razor, Pyzor,
and/or SPF code that made way too much noise.

Daniel

-- 
Daniel Quinlan
http://www.pathname.com/~quinlan/