You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/03/23 00:08:37 UTC
[GitHub] spark pull request #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support o...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/17392
[SPARK-20008] [SQL] DISTINCT and EXCEPT Support on DataFrame with Zero Columns
### What changes were proposed in this pull request?
So far, our aggregate does not consider the input with zero column. This PR is to fix the issue.
After the fix, both `DISTINCT` and `EXCEPT` can correctly behave when the DataFrame has zero column.
### How was this patch tested?
Added test cases to check both in different scenarios.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark emptyDF
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17392
----
commit c0c821f9056debf9385708d0cc0a0517261a5b7b
Author: Xiao Li <ga...@gmail.com>
Date: 2017-03-23T00:04:48Z
fix.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support on DataF...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17392
**[Test build #75075 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75075/testReport)** for PR 17392 at commit [`91adf27`](https://github.com/apache/spark/commit/91adf27f45e8ab9ed095e0ad06690276d6d68d73).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support on DataF...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17392
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support on DataF...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17392
**[Test build #75071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75071/testReport)** for PR 17392 at commit [`c0c821f`](https://github.com/apache/spark/commit/c0c821f9056debf9385708d0cc0a0517261a5b7b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support on DataF...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17392
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support o...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17392#discussion_r107569402
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectHashAggregateExec.scala ---
@@ -147,9 +147,13 @@ case class ObjectHashAggregateExec(
object ObjectHashAggregateExec {
def supportsAggregate(aggregateExpressions: Seq[AggregateExpression]): Boolean = {
- aggregateExpressions.map(_.aggregateFunction).exists {
- case _: TypedImperativeAggregate[_] => true
- case _ => false
+ if (aggregateExpressions.isEmpty) {
+ false
--- End diff --
not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support on DataF...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17392
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75075/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support on DataF...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17392
**[Test build #75075 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75075/testReport)** for PR 17392 at commit [`91adf27`](https://github.com/apache/spark/commit/91adf27f45e8ab9ed095e0ad06690276d6d68d73).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support on DataF...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17392
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75071/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support o...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/17392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17392: [SPARK-20008] [SQL] DISTINCT and EXCEPT Support on DataF...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17392
**[Test build #75071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75071/testReport)** for PR 17392 at commit [`c0c821f`](https://github.com/apache/spark/commit/c0c821f9056debf9385708d0cc0a0517261a5b7b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org