[jira] [Commented] (PHOENIX-6212) Improve SystemCatalogIT.testSystemTableSplit() to ensure no splitting occurs when splitting is disabled

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229650#comment-17229650 ] 

ASF GitHub Bot commented on PHOENIX-6212:
-----------------------------------------

ChinmaySKulkarni opened a new pull request #962:
URL: https://github.com/apache/phoenix/pull/962


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve SystemCatalogIT.testSystemTableSplit() to ensure no splitting occurs when splitting is disabled
> -------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6212
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6212
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.0.0, 4.15.0
>            Reporter: Chinmay Kulkarni
>            Assignee: Chinmay Kulkarni
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>
> We should fix [SystemCatalogIT.testSystemTableSplit()|https://github.com/apache/phoenix/blob/8aa243d1e35a2a9ac85c6c30f1e958289973c214/phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogIT.java#L65] so that it ensures that splitting SYSTEM.CATALOG fails if either 
> phoenix.allow.system.catalog.rollback=true and/or
> phoenix.system.catalog.splittable=false
> Currently this test is not really ensuring that a split fails (see [this comment|https://github.com/apache/phoenix/pull/949#discussion_r516276781] for more details)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)