[GitHub] [incubator-mxnet] junrushao1994 opened a new pull request #14409: [Numpy] Change semantics of ndim for operators in `src/operator/contrib`

[GitBox <gi...@apache.org>]

junrushao1994 opened a new pull request #14409: [Numpy] Change semantics of ndim for operators in `src/operator/contrib`
URL: https://github.com/apache/incubator-mxnet/pull/14409
 
 
   (This is the PR to the numpy branch, so please be aware it is not aimed for production until the numpy branch is merged successfully)
   
   This PR in part of progress of #14323, which contains improvement of the following contrib operators.
   
   - [x] adamw-inl.h
   - [x] adaptive_avg_pooling-inl.h
   - [x] bilinear_resize-inl.h
   - [x] bounding_box-inl.h
   - [x] count_sketch-inl.h
   - [x] deformable_convolution-inl.h
   - [x] fft-inl.h
   - [x] ifft-inl.h
   - [x] index_copy-inl.h
   - [x] multi_proposal-inl.h
   - [x] proposal-inl.h
   - [x] quadratic_op-inl.h
   - [x] sync_batch_norm-inl.h
   - [x] transformer-inl.h
   
   In addition to the header files assigned to me, I also change some of the following `.cc` files which relates to `ndim`. I am not 100% sure about the coverage, so reviewers please let me know if there is anything I left.
   - [x] boolean_mask.cc
   - [x] dgl_graph.cc
   - [x] nnvm_to_onnx.cc
   - [x] optimizer_op.cc
   
   The contrib operators are mostly irregular workloads coming from many contributors, which is one of the most difficult part (another difficult part is customized/python operators). I am trying my best not to break it. However, if there is anything I didn't take into consideration, please don't hesitate to let me know. Many thanks!
   
   CC: @reminisce @szha @eric-haibin-lin @zheng-da @yzhliu

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services