You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/08 11:02:07 UTC

[GitHub] [iceberg] pvary commented on pull request #2052: Hive: Fix join issues when CBO is enabled

pvary commented on pull request #2052:
URL: https://github.com/apache/iceberg/pull/2052#issuecomment-756694642


   Thanks for the patch @qphien!
   Really appreciate that you have taken the time to track this down!
   
   Asked a few questions in the review comments. The general observations:
   - Please do not do formatting only changes - These are making the review (and backport) harder
   - I would recommend to use a boolean or Boolean instead of "false"/"true" strings
   - There is one particular line I personally removed once accidentally and later realized that it is needed for performant queries (we might want to add a test case for it 😄). I think the line is still needed.
   - I asked @marton-bod to review the projection related part since he was the one working on that.
   
   Thanks,
   Peter


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org