You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "yesamer (via GitHub)" <gi...@apache.org> on 2024/03/15 16:52:14 UTC
[PR] kie-issues#1014: KIE Sandbox: Enabling Validation for DMN Assets up to 1.5 [incubator-kie-tools]
yesamer opened a new pull request, #2200:
URL: https://github.com/apache/incubator-kie-tools/pull/2200
Closes https://github.com/apache/incubator-kie-issues/issues/1014
The alternative is to remove that block of code, but I guess it will be useful to have for future DMN versions... (1.6 is coming... :) )
@ljmotta @tiagobento
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1014: KIE Sandbox: Enabling Validation for DMN Assets up to 1.5 [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2200:
URL: https://github.com/apache/incubator-kie-tools/pull/2200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1014: KIE Sandbox: Enabling Validation for DMN Assets up to 1.5 [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #2200:
URL: https://github.com/apache/incubator-kie-tools/pull/2200#issuecomment-2000194408
@tiagobento The main PR we implemented for DMN 1.5 was merged at the end of January ([here](https://github.com/apache/incubator-kie-drools/pull/5669)). That means the 02-18 snapshot supports 1.5, but not all the new features. Moreover, we need to wait next snapshot (03-17) to have a 100% compatible validation logic with all 1.5 features.
Considering we're targeting 10.0 release, I don't believe it's not risky to merge it now.
In addition, I would appreciate having it merged because we're using the dev environment (https://sandbox.kie.org/dev/#/) to test the editor-jitexecutor integration, and enabling the Validation there would help a lot.
However, if you prefer to postpone the merge after the update to the 03-17 snapshot update to minimize any risk, that's fine for me, I trust your judgment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1014: KIE Sandbox: Enabling Validation for DMN Assets up to 1.5 [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2200:
URL: https://github.com/apache/incubator-kie-tools/pull/2200#issuecomment-2000236081
@yesamer Great. Thanks for the details. I'm absolutely fine to merge it now. Don't need to wait for all validation capabilities to be available to merge it. Approving!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1014: KIE Sandbox: Enabling Validation for DMN Assets up to 1.5 [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2200:
URL: https://github.com/apache/incubator-kie-tools/pull/2200#issuecomment-2000112031
@yesamer Thank you for this PR! I have to say, however, that we won't see the effects of https://github.com/apache/incubator-kie-drools/pull/5785 in KIE Sandbox until we upgrade KIE Tools to a new timestamped SNAPSHOT of Kogito Runtimes... Btw, is 999-20240218-SNAPSHOT already compatible with DMN 1.5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org