You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/21 12:28:41 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

tillrohrmann opened a new pull request #13727:
URL: https://github.com/apache/flink/pull/13727


   Backport of #13725 to `release-1.10`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13727:
URL: https://github.com/apache/flink/pull/13727#issuecomment-713572668


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/191431633",
       "triggerID" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e2aaf84d255adab8420800d5e7ec20d502868f4",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/191598195",
       "triggerID" : "8e2aaf84d255adab8420800d5e7ec20d502868f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e2aaf84d255adab8420800d5e7ec20d502868f4 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/191598195) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13727:
URL: https://github.com/apache/flink/pull/13727#issuecomment-713572668


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c2ae5ba37a69ad1f40f585421d38edb30d40c0fa UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13727:
URL: https://github.com/apache/flink/pull/13727#issuecomment-713572668


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/191431633",
       "triggerID" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c2ae5ba37a69ad1f40f585421d38edb30d40c0fa Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/191431633) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #13727:
URL: https://github.com/apache/flink/pull/13727


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #13727:
URL: https://github.com/apache/flink/pull/13727#issuecomment-715321347


   Thanks for the review @rmetzger. Merging this PR now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13727:
URL: https://github.com/apache/flink/pull/13727#issuecomment-713572668


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/191431633",
       "triggerID" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e2aaf84d255adab8420800d5e7ec20d502868f4",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/191598195",
       "triggerID" : "8e2aaf84d255adab8420800d5e7ec20d502868f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c2ae5ba37a69ad1f40f585421d38edb30d40c0fa Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/191431633) 
   * 8e2aaf84d255adab8420800d5e7ec20d502868f4 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/191598195) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13727:
URL: https://github.com/apache/flink/pull/13727#issuecomment-713572668


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/191431633",
       "triggerID" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e2aaf84d255adab8420800d5e7ec20d502868f4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8e2aaf84d255adab8420800d5e7ec20d502868f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c2ae5ba37a69ad1f40f585421d38edb30d40c0fa Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/191431633) 
   * 8e2aaf84d255adab8420800d5e7ec20d502868f4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #13727:
URL: https://github.com/apache/flink/pull/13727#issuecomment-715321835


   Manually merged via 933041b3d8d192391437e343857f1dec14c544d1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13727:
URL: https://github.com/apache/flink/pull/13727#issuecomment-713534943


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c2ae5ba37a69ad1f40f585421d38edb30d40c0fa (Wed Oct 21 12:31:28 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13727: [BP-1.10][FLINK-19557] Trigger LeaderRetrievalListener notification upon ZooKeeper reconnection in ZooKeeperLeaderRetrievalService

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13727:
URL: https://github.com/apache/flink/pull/13727#issuecomment-713572668


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/191431633",
       "triggerID" : "c2ae5ba37a69ad1f40f585421d38edb30d40c0fa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c2ae5ba37a69ad1f40f585421d38edb30d40c0fa Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/191431633) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org