You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "leizhiyuan (via GitHub)" <gi...@apache.org> on 2026/08/11 05:08:09 UTC

[PR] feat(tencent): support consumer group management on Tencent Cloud RocketMQ 5.x instances [rocketmq-dashboard]

leizhiyuan opened a new pull request, #1591:
URL: https://github.com/apache/rocketmq-dashboard/pull/1591

   ## Summary
   
   Adds consumer group management support for Tencent Cloud RocketMQ 5.x instances on the
   `rocketmq-studio` branch, mapping the Tencent `provider/tencent` (Trocket v20230308 OpenAPI) to
   the instance-scoped consumer group CRUD surface. Fixes #1590.
   
   ## Changes
   
   **Consumer group management (Tencent provider)**
   - `listConsumerGroups` - `DescribeConsumerGroupList` pagination + name filter; enriches per-group
     `createdAt` and the real `ConsumeModel` via `DescribeConsumerGroup` (off the cheap count path).
   - `createConsumerGroup` / `deleteConsumerGroup` - `CreateConsumerGroup` / `DeleteConsumerGroup`
     with retry times and orderly-delivery defaults.
   - `getGroupProgress` / `getGroupSubscriptions` - `DescribeTopicListByGroup` mapping per-topic
     consumer lag and subscription entries.
   - `resetOffset` - `ResetConsumerGroupOffset` by timestamp (topic required).
   - `countGroups` - cheap list path without N+1 detail lookups.
   
   **Fix: blank group detail modal**
   - `instances` and `subscribedTopics` are now set to empty lists instead of `null`, so the detail
     modal no longer throws `Cannot read properties of null (reading 'length')` when opened.
   
   **SDK bump**
   - `tencentcloud-sdk-java-trocket` `3.1.1292` -> `3.1.1498`, which adds
     `DescribeConsumerGroupResponse#getConsumeModel()` to map `ConsumeModel` (CLUSTERING /
     BROADCASTING) to `ConsumeType`. The older model could not read this field.
   
   ## Testing
   - Unit tests added for the Tencent provider: list (mapping + consume model + timestamps + empty
     instances), create, delete, progress/subscriptions, and reset offset.
   - Backend: `mvn test` passes (893+ tests, 0 failures); checkstyle clean.
   - Manually verified against a real Tencent Cloud RocketMQ 5.x instance: group list shows real
     `createdAt` and `consumeType`, create/delete/reset work, and opening group detail no longer
     blanks the page.
   
   ## Notes
   - Scoped to `rocketmq-studio`; message query and trace ops for Tencent remain unsupported.
   - `subscriptionMode` (Push/Pop) and `subscriptionDataType` are not exposed by the Tencent API and
     remain empty, consistent with the Aliyun provider.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(tencent): support consumer group management on Tencent Cloud RocketMQ 5.x instances [rocketmq-dashboard]

Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan commented on PR #1591:
URL: https://github.com/apache/rocketmq-dashboard/pull/1591#issuecomment-5249232616

   <img width="1383" height="417" alt="Clipboard_Screenshot_1786425039" src="https://github.com/user-attachments/assets/f65179e5-af9a-4f50-b37e-724f471b96d5" />
   
   <img width="939" height="637" alt="Clipboard_Screenshot_1786425048" src="https://github.com/user-attachments/assets/cc274f98-8e56-4864-8a45-db07f28aabdc" />
   
   <img width="1146" height="323" alt="Clipboard_Screenshot_1786425062" src="https://github.com/user-attachments/assets/bf59709a-b30e-401c-a925-36a215d9bdc2" />
   
   test ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(tencent): support consumer group management on Tencent Cloud RocketMQ 5.x instances [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1591:
URL: https://github.com/apache/rocketmq-dashboard/pull/1591#issuecomment-5253454185

   Closing as superseded: same author's #1641 is a broader superset (consumer group management + message query/Trace, 19 files) and both PRs modify TencentInstanceProvider, so they conflict. Continuing with #1641.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(tencent): support consumer group management on Tencent Cloud RocketMQ 5.x instances [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1591: feat(tencent): support consumer group management on Tencent Cloud RocketMQ 5.x instances
URL: https://github.com/apache/rocketmq-dashboard/pull/1591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org