[GitHub] reminisce commented on a change in pull request #9200: Fix the gradient of gather_nd

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #9200: Fix the gradient of gather_nd
URL: https://github.com/apache/incubator-mxnet/pull/9200#discussion_r158871673
 
 

 ##########
 File path: src/operator/tensor/indexing_op.cu
 ##########
 @@ -209,6 +240,9 @@ NNVM_REGISTER_OP(gather_nd)
 NNVM_REGISTER_OP(scatter_nd)
 .set_attr<FCompute>("FCompute<gpu>", ScatterNDForward<gpu>);
 
+NNVM_REGISTER_OP(scatter_nd_acc)
 
 Review comment:
   The string `acc` looks ambiguous. I thought it standed for `accurate` in the beginning, but realized that it means `accumulate` later. It's named `scatter_nd_add` in TF, as there are also `scatter_nd_sub`, `scatter_nd_mul`, and `scatter_nd_div`. Shall we also call it `scatter_nd_add` to be precise?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services