You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/04 12:49:27 UTC
[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #4105: fix: fix gitlab missing transformation rules
mindlesscloud opened a new pull request, #4105:
URL: https://github.com/apache/incubator-devlake/pull/4105
### Summary
Fix the gitlab plugin missing transformation rules
- set `transformationRuleId` to the `options` in the function `makePipelinePlanV200`
- find the transformation rule in the database by the `transformationRuleId`
- set the transformation rule to task data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #4105: fix: fix gitlab missing transformation rules
Posted by GitBox <gi...@apache.org>.
abeizn commented on code in PR #4105:
URL: https://github.com/apache/incubator-devlake/pull/4105#discussion_r1062137367
##########
plugins/gitlab/api/blueprint_v200.go:
##########
@@ -132,6 +132,7 @@ func makePipelinePlanV200(subtaskMetas []core.SubTaskMeta, scopes []*core.Bluepr
options := make(map[string]interface{})
options["connectionId"] = connection.ID
options["projectId"] = intScopeId
+ options["transformationRuleId"] = transformationRules.ID
Review Comment:
need to add it at blueprint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mindlesscloud commented on a diff in pull request #4105: fix: fix gitlab missing transformation rules
Posted by GitBox <gi...@apache.org>.
mindlesscloud commented on code in PR #4105:
URL: https://github.com/apache/incubator-devlake/pull/4105#discussion_r1062351673
##########
plugins/gitlab/api/blueprint_v200.go:
##########
@@ -132,6 +132,7 @@ func makePipelinePlanV200(subtaskMetas []core.SubTaskMeta, scopes []*core.Bluepr
options := make(map[string]interface{})
options["connectionId"] = connection.ID
options["projectId"] = intScopeId
+ options["transformationRuleId"] = transformationRules.ID
Review Comment:
After a discussion with @warren830 , we think it's OK to set `transformationRuleId` to options within the function `makePipelinePlanV200`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn merged pull request #4105: fix: fix gitlab missing transformation rules
Posted by GitBox <gi...@apache.org>.
abeizn merged PR #4105:
URL: https://github.com/apache/incubator-devlake/pull/4105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org