[GitHub] [flink] fapaul commented on a change in pull request #17776: [FLINK-24616][table] Add metadata from FileStatus in FileSystemTableSource

[GitBox <gi...@apache.org>]

fapaul commented on a change in pull request #17776:
URL: https://github.com/apache/flink/pull/17776#discussion_r749126367



##########
File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/FileSourceSplit.java
##########
@@ -91,9 +98,17 @@
      * @param filePath The path to the file.
      * @param offset The start (inclusive) of the split's rage in the file.
      * @param length The number of bytes in the split (starting from the offset)
+     * @param modificationTime The modification time of the file
+     * @param fileSize The size of the full file
      */
-    public FileSourceSplit(String id, Path filePath, long offset, long length) {
-        this(id, filePath, offset, length, NO_HOSTS);
+    public FileSourceSplit(

Review comment:
       Strictly speaking, we cannot easily do this change because the class is annotated with `@PublicEvolving` and the change might break existing setups.
   
   We definitely have to keep the old constructors in case someone is using them.

##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveSourceSplit.java
##########
@@ -63,10 +65,12 @@ public HiveSourceSplit(
             Path filePath,
             long offset,
             long length,
+            long modificationTime,
+            long fileSize,

Review comment:
       Same here we should not break the ctor of a `@PublicEvolving` class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org