You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/01/18 08:31:33 UTC
[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index
nit0906 commented on a change in pull request #465:
URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r786513708
##########
File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/PropertyValueImpl.java
##########
@@ -125,12 +125,7 @@ public void restrict(FilterImpl f, Operator operator, PropertyValue v) {
f.restrictPath(v.getValue(Type.STRING), PathRestriction.EXACT);
}
} else {
- if (operator == Operator.NOT_EQUAL && v != null) {
- // "x <> 1" also means "x is not null"
- f.restrictProperty(pn, Operator.NOT_EQUAL, null, propertyType);
Review comment:
@thomasmueller - propertyIndex could still use it - because in restrictProperty method in FilterImpl, I added new varaibles to handle inequality, which would effectively leave the old behaviour for PropertyIndex as it is.
Changes in Filter.java and FilterImpl.java should handle this.
btw, there's a case with older version of lucene that fails - (version 1) - I am still looking into that , so there might be further changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org