You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "alhudz (via GitHub)" <gi...@apache.org> on 2026/08/14 12:29:53 UTC
[PR] keep stripStart and stripEnd off surrogate pair boundaries [commons-lang]
alhudz opened a new pull request, #1773:
URL: https://github.com/apache/commons-lang/pull/1773
Repro: `StringUtils.stripStart("𝔞abc", "𝔟")` — input starts with U+1D51E, the strip set holds only U+1D51F, and the two share the high surrogate `\uD835`.
Expected: `"𝔞abc"` unchanged, since U+1D51E is not in `{U+1D51F}`.
Actual: `"\uDD1Eabc"` — only the high surrogate is removed, so a well-formed input becomes ill-formed UTF-16. `stripEnd`/`strip`/`stripAll` corrupt the same way against a supplementary strip character that shares either surrogate half (for example `stripEnd("abc𝄞", "𝔞")` returns `"abc\uD834"`).
Cause: both membership loops test one `char` at a time with `stripChars.indexOf(str.charAt(...))`, and `String.indexOf(char)` matches a single surrogate half of a supplementary set character.
Fix: walk the strip membership by code point (`codePointAt`/`codePointBefore` + `Character.charCount`) so a supplementary strip character only matches a whole code point and the cut can never land inside a pair. The already surrogate-aware `containsAny`/`containsNone`/`indexOfAny`/`indexOfAnyBut` agree the character is not a member on these inputs. BMP input and the `null` (whitespace) path are unchanged.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
- [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep stripStart and stripEnd off surrogate pair boundaries [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1773:
URL: https://github.com/apache/commons-lang/pull/1773#issuecomment-5294447000
Thank you @alhudz , merged 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep stripStart and stripEnd off surrogate pair boundaries [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #1773:
URL: https://github.com/apache/commons-lang/pull/1773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org