You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "maxxedev (via GitHub)" <gi...@apache.org> on 2023/04/23 04:02:12 UTC

[GitHub] [commons-io] maxxedev opened a new pull request, #453: Apply nanoseconds precision for timeout duration.

maxxedev opened a new pull request, #453:
URL: https://github.com/apache/commons-io/pull/453

   ```
   Apply nanoseconds precision for timeout duration.
   Also improve javadocs
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] codecov-commenter commented on pull request #453: Apply nanoseconds precision for timeout duration.

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #453:
URL: https://github.com/apache/commons-io/pull/453#issuecomment-1518951170

   ## [Codecov](https://codecov.io/gh/apache/commons-io/pull/453?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#453](https://codecov.io/gh/apache/commons-io/pull/453?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a339fe) into [master](https://codecov.io/gh/apache/commons-io/commit/7be5b5921b7b65e6d50413f73872341cbb557e6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7be5b59) will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #453   +/-   ##
   =========================================
     Coverage     84.73%   84.73%           
     Complexity     3293     3293           
   =========================================
     Files           222      222           
     Lines          7912     7912           
     Branches        948      948           
   =========================================
     Hits           6704     6704           
     Misses          959      959           
     Partials        249      249           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-io/pull/453?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/commons/io/input/QueueInputStream.java](https://codecov.io/gh/apache/commons-io/pull/453?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvaW8vaW5wdXQvUXVldWVJbnB1dFN0cmVhbS5qYXZh) | `96.29% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] garydgregory merged pull request #453: Apply nanoseconds precision for timeout duration.

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #453:
URL: https://github.com/apache/commons-io/pull/453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] maxxedev commented on pull request #453: Apply nanoseconds precision for timeout duration.

Posted by "maxxedev (via GitHub)" <gi...@apache.org>.
maxxedev commented on PR #453:
URL: https://github.com/apache/commons-io/pull/453#issuecomment-1518952497

   The timeout is configurable through the public API with a `Duration` value which encapsulates both time amount and time unit.
   
   This PR changes so that internal usage and conversion of Duration is more precise up to nanoseconds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org