You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/26 05:40:03 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #13904: Only show User's local timezone if it's not UTC
jedcunningham opened a new pull request #13904:
URL: https://github.com/apache/airflow/pull/13904
Instead of duplicating the same UTC start/end dates in the Task Instance tooltip, only show the users local formatted start/end dates if it's not UTC.
Before:
After:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #13904: Only show User's local timezone if it's not UTC
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #13904:
URL: https://github.com/apache/airflow/pull/13904#issuecomment-767661938
I don't have a strong preference, though I do lean towards "UTC" vs "Local: UTC (+00:00)". The consistency thing cuts both ways too. We will always show UTC, but it would be labeled differently if you have a local timezone selected. However, as I said, I don't have a strong preference so let me know which you'd like to move forward with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #13904: Only show User's local timezone if it's not UTC
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #13904:
URL: https://github.com/apache/airflow/pull/13904
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #13904: Only show User's local timezone if it's not UTC
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #13904:
URL: https://github.com/apache/airflow/pull/13904
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #13904: Only show User's local timezone if it's not UTC
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #13904:
URL: https://github.com/apache/airflow/pull/13904#issuecomment-767595814
@jedcunningham I like this update. I'm wondering if it might be better to make the "UTC" timestamps themselves conditional instead (when "Local" is not UTC)? Very similar result (see below), but then you'll consistently have a labeling/confirmation of what the "Local" timezone is. If you agree with that strategy, I'd also suggest swapping the order so the "Local" timestamps come before the "UTC" timestamps as that will keep all of the tooltips more consistent with the conditional info at the tail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org