You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Surya Hebbar (Code Review)" <ge...@cloudera.org> on 2024/03/20 16:29:54 UTC

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Surya Hebbar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21173


Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................

IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

On horizontally scrolling the query timeline after zooming, the controls
and navigation bar at the top of the page move away from the visibility
area. This makes it difficult to use the controls while scrolling.

The controls and navigation bar now stay within the visibility area even
after scrolling horizontally, allowing for easier navigation.

Hovering on the edges to scroll horizontally is also supported as before.

Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
---
M www/query_timeline.tmpl
M www/scripts/query_timeline/fragment_diagram.js
M www/scripts/query_timeline/fragment_metrics_diagram.js
M www/scripts/query_timeline/host_utilization_diagram.js
4 files changed, 35 insertions(+), 33 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/21173/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2024 04:05:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10399/


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2024 09:12:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 2:

The failure seems to be for some other reason unrelated to the changes in this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2024 12:44:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 1: Code-Review+1

Looks OK. Tested it in my local machine and zooming stretch the timeline just to right direction instead of both left and right before this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 22:32:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2024 04:04:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10399/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2024 04:05:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................

IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

On horizontally scrolling the query timeline after zooming, the controls
and navigation bar at the top of the page move away from the visibility
area. This makes it difficult to use the controls while scrolling.

The controls and navigation bar now stay within the visibility area even
after scrolling horizontally, allowing for easier navigation.

Hovering on the edges to scroll horizontally is also supported as before.

Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Reviewed-on: http://gerrit.cloudera.org:8080/21173
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M www/query_timeline.tmpl
M www/scripts/query_timeline/fragment_diagram.js
M www/scripts/query_timeline/fragment_metrics_diagram.js
M www/scripts/query_timeline/host_utilization_diagram.js
4 files changed, 35 insertions(+), 33 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 4
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 3
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2024 16:12:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 3
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2024 21:17:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15585/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 16:54:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21173 )

Change subject: IMPALA-12923: Fix header alignment during horizontal scrolling in query timeline
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10405/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3b248554ba32766c29faf91c791f2dbbd20641e
Gerrit-Change-Number: 21173
Gerrit-PatchSet: 3
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2024 16:12:31 +0000
Gerrit-HasComments: No