You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by andresteingress <gi...@git.apache.org> on 2016/05/07 17:23:45 UTC

[GitHub] groovy pull request: GROOVY-7697: GroovyScriptEngine.loadScriptByN...

GitHub user andresteingress opened a pull request:

    https://github.com/apache/groovy/pull/330

    GROOVY-7697: GroovyScriptEngine.loadScriptByName doesn't support envi\u2026

    \u2026ronment variable "groovy.ast"
    
    This PR fixes an issue where the "groovy.ast" dump (only god, its author and the ticket author knew this existed) would not be saved when a script was loaded by name via the GSE. In that case, the `XStreamUtils` instance was given an URI (String) instead of an absolute path and the code there broke.
    
    Regarding error handling in `XStreamUtils` (as this was also mentioned in the ticket): I did not change anything into that direction as I am not convinced that such a secondary "add-on" feature should in any way influence behaviour in `SourceUnit#convert`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andresteingress/groovy GROOVY-7697

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #330
    
----
commit 70fee35eef16dd68128410a5f51e1ed94742b47a
Author: Andre Steingress <me...@andresteingress.com>
Date:   2016-05-07T16:58:39Z

    GROOVY-7697: GroovyScriptEngine.loadScriptByName doesn't support environment variable "groovy.ast"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #330: GROOVY-7697: GroovyScriptEngine.loadScriptByName d...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/330


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---