You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/05/05 23:33:06 UTC
Re: Review Request 20997: Fix KAFKA-1432: address Neha's comments
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20997/
-----------------------------------------------------------
(Updated May 5, 2014, 9:33 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Fix KAFKA-1432: address Neha's comments
Bugs: KAFKA-1432
https://issues.apache.org/jira/browse/KAFKA-1432
Repository: kafka
Description (updated)
-------
Address Neha's comments
Address Jun's comments
Add new TransitProducer
KAFKA-1432.v1
Diffs (updated)
-----
core/src/main/scala/kafka/producer/BaseProducer.scala PRE-CREATION
core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 988e4374d8c9b30c9333369741c30c75f0c44f2c
core/src/main/scala/kafka/producer/ConsoleProducer.scala b19ab49c5fd57423e142f2f8afc5a77e653fd6ed
core/src/main/scala/kafka/tools/MirrorMaker.scala e4d1a86f673f7df7fe71ce44e3550fcde8d01bba
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala a969a22c6b82ed5c9f053a50594b1c7a768efd0e
perf/src/main/scala/kafka/perf/ProducerPerformance.scala 1490bdb3d52d5c901d7a464222284935bda2f7ca
system_test/utils/kafka_system_test_utils.py 423b512983c77b41b819912fe67b375a78faf644
Diff: https://reviews.apache.org/r/20997/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 20997: Fix KAFKA-1432: address Neha's comments
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20997/#review42376
-----------------------------------------------------------
system_test/utils/kafka_system_test_utils.py
<https://reviews.apache.org/r/20997/#comment76155>
Shouldn't we add the --new-producer option?
- Jun Rao
On May 5, 2014, 10:24 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20997/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 10:24 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1432
> https://issues.apache.org/jira/browse/KAFKA-1432
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Address Neha's comments round two
>
>
> Address Neha's comments
>
>
> Address Jun's comments
>
>
> Add new TransitProducer
>
>
> KAFKA-1432.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/producer/BaseProducer.scala PRE-CREATION
> core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 988e4374d8c9b30c9333369741c30c75f0c44f2c
> core/src/main/scala/kafka/producer/ConsoleProducer.scala b19ab49c5fd57423e142f2f8afc5a77e653fd6ed
> core/src/main/scala/kafka/tools/MirrorMaker.scala e4d1a86f673f7df7fe71ce44e3550fcde8d01bba
> core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala a969a22c6b82ed5c9f053a50594b1c7a768efd0e
> perf/src/main/scala/kafka/perf/ProducerPerformance.scala 1490bdb3d52d5c901d7a464222284935bda2f7ca
> system_test/utils/kafka_system_test_utils.py 423b512983c77b41b819912fe67b375a78faf644
>
> Diff: https://reviews.apache.org/r/20997/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 20997: Fix KAFKA-1432: address Neha's comments
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20997/#review42221
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On May 5, 2014, 10:24 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20997/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 10:24 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1432
> https://issues.apache.org/jira/browse/KAFKA-1432
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Address Neha's comments round two
>
>
> Address Neha's comments
>
>
> Address Jun's comments
>
>
> Add new TransitProducer
>
>
> KAFKA-1432.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/producer/BaseProducer.scala PRE-CREATION
> core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 988e4374d8c9b30c9333369741c30c75f0c44f2c
> core/src/main/scala/kafka/producer/ConsoleProducer.scala b19ab49c5fd57423e142f2f8afc5a77e653fd6ed
> core/src/main/scala/kafka/tools/MirrorMaker.scala e4d1a86f673f7df7fe71ce44e3550fcde8d01bba
> core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala a969a22c6b82ed5c9f053a50594b1c7a768efd0e
> perf/src/main/scala/kafka/perf/ProducerPerformance.scala 1490bdb3d52d5c901d7a464222284935bda2f7ca
> system_test/utils/kafka_system_test_utils.py 423b512983c77b41b819912fe67b375a78faf644
>
> Diff: https://reviews.apache.org/r/20997/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 20997: Fix KAFKA-1432: address Neha's comments
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20997/
-----------------------------------------------------------
(Updated May 5, 2014, 10:24 p.m.)
Review request for kafka.
Bugs: KAFKA-1432
https://issues.apache.org/jira/browse/KAFKA-1432
Repository: kafka
Description (updated)
-------
Address Neha's comments round two
Address Neha's comments
Address Jun's comments
Add new TransitProducer
KAFKA-1432.v1
Diffs (updated)
-----
core/src/main/scala/kafka/producer/BaseProducer.scala PRE-CREATION
core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 988e4374d8c9b30c9333369741c30c75f0c44f2c
core/src/main/scala/kafka/producer/ConsoleProducer.scala b19ab49c5fd57423e142f2f8afc5a77e653fd6ed
core/src/main/scala/kafka/tools/MirrorMaker.scala e4d1a86f673f7df7fe71ce44e3550fcde8d01bba
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala a969a22c6b82ed5c9f053a50594b1c7a768efd0e
perf/src/main/scala/kafka/perf/ProducerPerformance.scala 1490bdb3d52d5c901d7a464222284935bda2f7ca
system_test/utils/kafka_system_test_utils.py 423b512983c77b41b819912fe67b375a78faf644
Diff: https://reviews.apache.org/r/20997/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 20997: Fix KAFKA-1432: address Neha's comments
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20997/#review42212
-----------------------------------------------------------
core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/20997/#comment75975>
This needs to change as well right? Maybe something like mirrormaker-consumer
core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/20997/#comment75976>
For consistency, this should be mirrormaker-producer
- Neha Narkhede
On May 5, 2014, 9:33 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20997/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 9:33 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1432
> https://issues.apache.org/jira/browse/KAFKA-1432
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Address Neha's comments
>
>
> Address Jun's comments
>
>
> Add new TransitProducer
>
>
> KAFKA-1432.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/producer/BaseProducer.scala PRE-CREATION
> core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala 988e4374d8c9b30c9333369741c30c75f0c44f2c
> core/src/main/scala/kafka/producer/ConsoleProducer.scala b19ab49c5fd57423e142f2f8afc5a77e653fd6ed
> core/src/main/scala/kafka/tools/MirrorMaker.scala e4d1a86f673f7df7fe71ce44e3550fcde8d01bba
> core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala a969a22c6b82ed5c9f053a50594b1c7a768efd0e
> perf/src/main/scala/kafka/perf/ProducerPerformance.scala 1490bdb3d52d5c901d7a464222284935bda2f7ca
> system_test/utils/kafka_system_test_utils.py 423b512983c77b41b819912fe67b375a78faf644
>
> Diff: https://reviews.apache.org/r/20997/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>