You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2015/04/03 22:26:49 UTC

[1/2] trafficserver git commit: TS-3479 Remove verbose Warning() from HTTP/2 connections

Repository: trafficserver
Updated Branches:
  refs/heads/5.3.x 7bfa66647 -> 42e8f7c45


TS-3479 Remove verbose Warning() from HTTP/2 connections


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/dc0e9cf0
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/dc0e9cf0
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/dc0e9cf0

Branch: refs/heads/5.3.x
Commit: dc0e9cf03c827e2b9592d5ef35dc3dfb508ccbfb
Parents: 7bfa666
Author: Leif Hedstrom <zw...@apache.org>
Authored: Wed Apr 1 16:50:30 2015 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Fri Apr 3 14:20:45 2015 -0600

----------------------------------------------------------------------
 CHANGES                           | 2 ++
 proxy/http2/Http2SessionAccept.cc | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/dc0e9cf0/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 9a6c8ef..e2a4aea 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,8 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache Traffic Server 5.3.0
 
+  *) [TS-3479] Remove verbose Warning() from HTTP/2 connections.
+
   *) [TS-3470] traffic_server --help segfaults when SPDY is enabled.
 
   *) [TS-3491] background_fetch: Only release URL if we were scheduled.

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/dc0e9cf0/proxy/http2/Http2SessionAccept.cc
----------------------------------------------------------------------
diff --git a/proxy/http2/Http2SessionAccept.cc b/proxy/http2/Http2SessionAccept.cc
index 5fe2ce7..fbb25db 100644
--- a/proxy/http2/Http2SessionAccept.cc
+++ b/proxy/http2/Http2SessionAccept.cc
@@ -40,7 +40,7 @@ Http2SessionAccept::accept(NetVConnection *netvc, MIOBuffer *iobuf, IOBufferRead
 {
   // XXX we need to refactor the ACL checks from HttpSessionAccept so that we can invoke them here, and also in
   // the SPDY protocol layer ...
-  Warning("skipping access control checks for HTTP/2 connection");
+  // Warning("skipping access control checks for HTTP/2 connection");
 
   netvc->attributes = this->options.transport_type;
 


[2/2] trafficserver git commit: TS-3479 Add back the warning, but only once at startup

Posted by so...@apache.org.
TS-3479 Add back the warning, but only once at startup


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/42e8f7c4
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/42e8f7c4
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/42e8f7c4

Branch: refs/heads/5.3.x
Commit: 42e8f7c453618987cedcf1f811823fac7957e74d
Parents: dc0e9cf
Author: Leif Hedstrom <zw...@apache.org>
Authored: Thu Apr 2 22:19:42 2015 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Fri Apr 3 14:20:46 2015 -0600

----------------------------------------------------------------------
 lib/records/RecHttp.cc | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/42e8f7c4/lib/records/RecHttp.cc
----------------------------------------------------------------------
diff --git a/lib/records/RecHttp.cc b/lib/records/RecHttp.cc
index 2854813..b317e57 100644
--- a/lib/records/RecHttp.cc
+++ b/lib/records/RecHttp.cc
@@ -617,6 +617,8 @@ ts_session_protocol_well_known_name_indices_init()
   REC_ReadConfigInteger(http2_enabled, "proxy.config.http2.enabled");
   if (!http2_enabled) {
     DEFAULT_TLS_SESSION_PROTOCOL_SET.markOut(HTTP2_PROTOCOL_SET);
+  } else {
+    Warning("Be aware that access control checks for HTTP/2 connections are not active!");
   }
 
   DEFAULT_NON_TLS_SESSION_PROTOCOL_SET = HTTP_PROTOCOL_SET;