You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stacic <gi...@git.apache.org> on 2014/08/14 21:55:02 UTC
[GitHub] cordova-plugin-contacts pull request: Add missing test, skip some ...
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/41
Add missing test, skip some specs on wp
Added in a few things that were added to mobile-spec after tests were
initially ported:
-new find method spec
-specs which require manual user confirmation on wp are skipped
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-plugin-contacts skipOnWindows
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit ceed0b783aa0179bfdafe7003e481f493cd4ec84
Author: Staci Cooper <sm...@us.ibm.com>
Date: 2014-08-14T19:51:59Z
Add missing test, skip some specs on wp
Added in a few things that were added to mobile-spec after tests were
initially ported:
-new find method spec
-specs which require manual user confirmation on wp are skipped
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add missing test, skip some ...
Posted by mmocny <gi...@git.apache.org>.
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/41#issuecomment-52351394
Looks good, but I didn't test on windows.
Additionally, we should write define/it helpers that accept a list of platforms to include/exclude so that we don't have to handle this inline.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add missing test, skip some ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---