You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by "xiangrong,chen (JIRA)" <ji...@apache.org> on 2017/08/28 06:32:00 UTC

[jira] [Closed] (GRIFFIN-38) Server code review 2017-07-21

     [ https://issues.apache.org/jira/browse/GRIFFIN-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

xiangrong,chen closed GRIFFIN-38.
---------------------------------
    Resolution: Fixed

> Server code review 2017-07-21 
> ------------------------------
>
>                 Key: GRIFFIN-38
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-38
>             Project: Griffin (Incubating)
>          Issue Type: Bug
>            Reporter: xiangrong,chen
>            Assignee: William Guo
>
> 1. testcase for Jsonconvert, consider if it is necessary.
> 2. All basic util method should be in one class
> 3. Livy ApI has its own utility class，and we should use it directly.
> 4. JobInstance -->jobDetail, consider the necessarity of JobInstance table.
> 5. "Page size" spring API habit, "page= size="
> 6. exception handler.
> 7. jobinstance status (should be enum type)
> 8. sparkJobDO, json note



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)