You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by necosta <gi...@git.apache.org> on 2018/03/13 16:18:45 UTC

[GitHub] zeppelin pull request #2864: Hotfix: R interpreter bugfix

GitHub user necosta opened a pull request:

    https://github.com/apache/zeppelin/pull/2864

    Hotfix: R interpreter bugfix

    ### What is this PR for?
    Failing to build R interpreter (-Pr) after Spark refactoring
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3325
    
    ### How should this be tested?
    * mvn clean package \
      --batch-mode package \
      -Phelium-dev \
      -Pscala-2.11 \
      -Dscala.version=2.11.8 \
      -Dscala.binary.version=2.11 \
      -Pbuild-distr \
      -Pspark-2.1 \
      -Dspark.version=2.1.1 \
      -Pr \
      -Pcassandra-spark-1.5 \
      -Psparkr \
      -Ppyspark \
      -Phadoop-2.7 \
      -Dhadoop.version=2.7.3 \
      -Dmaven.findbugs.enable=false \
      -Drat.skip=true \
      -Dcheckstyle.skip=true \
      -DskipTests
    
    ### Questions:
    * Does the licenses files need update? N
    * Is there breaking changes for older versions? N
    * Does this needs documentation? N


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nokia/zeppelin ZEPPELIN-3325

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2864
    
----
commit 14b0decca24c9ed9ff61d7dd1ed990e70d46d026
Author: Nelson Costa <ne...@...>
Date:   2018-03-13T14:50:29Z

    Hotfix: R interpreter bugfix

----


---

[GitHub] zeppelin issue #2864: Hotfix: R interpreter bugfix

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2864
  
    Thanks for contribution @necosta ， Could you update the jira title ？And also update the .travis.yml seems travis didn't cover r interpreter


---

[GitHub] zeppelin issue #2864: ZEPPELIN-3325: SparkR interpreter build bugfix

Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:

    https://github.com/apache/zeppelin/pull/2864
  
    Hi @Leemoonsoo , @zjffdu , @andreaTP
    
    Can I get a review?
    
    Rebased against latest master - 8818463, cherry-picked the change on https://github.com/apache/zeppelin/pull/2863 in order to get a green build.
    
    Running:
    `
    mvn clean package --batch-mode package -Phelium-dev -Pscala-2.11 -Dscala.version=2.11.8 -Dscala.binary.version=2.11 -Pbuild-distr -Pspark-2.1 -Dspark.version=2.1.1 -Pr -Pcassandra-spark-1.5 -Psparkr -Ppyspark -Phadoop-2.7 -Dhadoop.version=2.7.3 -Dmaven.findbugs.enable=false -Drat.skip=true -Dcheckstyle.skip=true -DskipTests
    `
    CI: https://travis-ci.org/nokia/zeppelin/builds/362558135
    
    Thanks


---

[GitHub] zeppelin issue #2864: ZEPPELIN-3325: R interpreter build bugfix

Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:

    https://github.com/apache/zeppelin/pull/2864
  
    ping @zjffdu 
    https://travis-ci.org/nokia/zeppelin/builds/368034675 (stage 4 looks broken)
    Thanks


---

[GitHub] zeppelin issue #2864: ZEPPELIN-3325: R interpreter build bugfix

Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:

    https://github.com/apache/zeppelin/pull/2864
  
    Ok, let me update on the issue.
    There was a confusion on my side between SparkR and R
    
    Latest master, ff4c0f3551df1, running:
    `
    mvn clean package --batch-mode package -Phelium-dev -Pscala-2.11 -Dscala.version=2.11.8 -Dscala.binary.version=2.11 -Pbuild-distr -Pspark-2.1 -Dspark.version=2.1.1 -Pr  -Dhadoop.version=2.7.3 -Dmaven.findbugs.enable=false -Drat.skip=true -Dcheckstyle.skip=true -DskipTests
    `
    Error: 
    `
    [INFO] Zeppelin: R Interpreter ............................ FAILURE [  1.221 s]
    [INFO] Zeppelin: Helium development interpreter ........... SKIPPED
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 23:39 min
    [INFO] Finished at: 2018-04-13T09:31:24+01:00
    [INFO] Final Memory: 372M/1979M
    [INFO] ------------------------------------------------------------------------
    [ERROR] Failed to execute goal on project zeppelin-zrinterpreter_2.10: Could not resolve dependencies for project org.apache.zeppelin:zeppelin-zrinterpreter_2.10:jar:0.9.0-SNAPSHOT: Could not find artifact org.apache.zeppelin:zeppelin-spark_2.11:jar:0.9.0-SNAPSHOT in apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
    `
    
    I applied my bugfix on top of latest master (also a code format correction on JDBC) and got a successful build with the same parameters.
    
    @zjffdu , another review? Thanks
    
    
    
    



---

[GitHub] zeppelin issue #2864: ZEPPELIN-3325: R interpreter build bugfix

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2864
  
    4 is flaky test, LGTM


---

[GitHub] zeppelin pull request #2864: ZEPPELIN-3325: R interpreter build bugfix

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2864


---