[GitHub] [pinot] walterddr commented on a diff in pull request #10977: allow to add custom context into query trace

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10977:
URL: https://github.com/apache/pinot/pull/10977#discussion_r1244329566


##########
pinot-core/src/main/java/org/apache/pinot/core/util/trace/BuiltInTracer.java:
##########
@@ -50,6 +50,15 @@ public void close() {
       }
       TraceContext.logTime(operatorName, duration);
     }
+
+    @Override
+    public void close(Object context) {
+      String operatorName = _operator.getSimpleName();
+      if (LOGGER.isTraceEnabled()) {

Review Comment:
   guessing this check is here to avoid unnecessary string concat? this is only needed if we pass in a function to trace right? for this format it is unnecessary? (CC @gortiz since we had similar discussion previously)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org