You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/07 02:25:53 UTC

[GitHub] [flink] chenyuzhi459 commented on a diff in pull request #18118: [FLINK-24907] Support side out late data for interval join

chenyuzhi459 commented on code in PR #18118:
URL: https://github.com/apache/flink/pull/18118#discussion_r964323275


##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/IntervalJoinITCase.java:
##########
@@ -155,6 +157,134 @@ public void testJoinsCorrectlyWithMultipleKeys() throws Exception {
                 "(key2,5):(key2,5)");
     }
 
+    @Test
+    public void testIntervalJoinSideOutputLeftLateData() throws Exception {

Review Comment:
   Thanks for your tips! I have merged the 2 tests into one test method by sideout the  late data of left and right side at the same time .
   
   Should I continue to  extracted  the `run` content ? Cause I am a little confuse about how to do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org