You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/08 16:04:00 UTC

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21739: Fix for increased FAILED_PRECONDITION errors in BQ Read API.

TheNeuralBit commented on code in PR #21739:
URL: https://github.com/apache/beam/pull/21739#discussion_r892571921


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -355,6 +356,7 @@ public synchronized BigQueryStorageStreamSource<T> getCurrentSource() {
                       .build(),
                   source.readSession.getTable());
           newResponseIterator = newResponseStream.iterator();
+          newResponseIterator.hasNext();

Review Comment:
   Would it be feasible to add a test that exercises this behavior? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org