[GitHub] [iceberg] fivetran-ashokborra commented on a diff in pull request #8056: Parquet: Junit5 upgrade

["fivetran-ashokborra (via GitHub)" <gi...@apache.org>]

fivetran-ashokborra commented on code in PR #8056:
URL: https://github.com/apache/iceberg/pull/8056#discussion_r1267100387


##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDeleteWriters.java:
##########
@@ -74,7 +74,7 @@ public void createDeleteRecords() {
 
   @Test
   public void testEqualityDeleteWriter() throws IOException {
-    File deleteFile = temp.newFile();
+    File deleteFile = temp;

Review Comment:
   The tests in TestParquetDeleteWriters.java expects the file to be actually created while the tests in TestParquet don't want the file to be present on the system, as it would throw file already exists exception



##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDeleteWriters.java:
##########
@@ -74,7 +74,7 @@ public void createDeleteRecords() {
 
   @Test
   public void testEqualityDeleteWriter() throws IOException {
-    File deleteFile = temp.newFile();
+    File deleteFile = temp;

Review Comment:
   The tests in TestParquetDeleteWriters.java expects the file to be actually created while the tests in TestParquet don't want the file to be present on the system, as it would throw file already exists exception



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org