[D] why rocksdb::GetSnapshot frequently used in v2.7 [kvrocks]

["qiwei9743 (via GitHub)" <gi...@apache.org>]

GitHub user qiwei9743 created a discussion: why rocksdb::GetSnapshot frequently used in v2.7

hi,
rocksdb::GetSnapshot() may impact performance if used frequently.  I find that it's used even when get a single key. May I know the reason behind the decision?

Thanks.

![image](https://github.com/user-attachments/assets/b3081c6f-1ce9-4980-abe7-ec633fa80708)



GitHub link: https://github.com/apache/kvrocks/discussions/2777

----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org

Re: [D] why rocksdb::GetSnapshot frequently used in v2.7 [kvrocks]

["mapleFU (via GitHub)" <gi...@apache.org>]

GitHub user mapleFU added a comment to the discussion: why rocksdb::GetSnapshot frequently used in v2.7

Yes, I think this can be removed. In fact this is refactor to use `engine::Context` in latest version, which tries to share the same Snapshopt if write doesn't happens

GitHub link: https://github.com/apache/kvrocks/discussions/2777#discussioncomment-12102439

----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org