You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "troizet (via GitHub)" <gi...@apache.org> on 2023/04/05 16:14:12 UTC
[GitHub] [netbeans] troizet opened a new pull request, #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
troizet opened a new pull request, #5779:
URL: https://github.com/apache/netbeans/pull/5779
```php
function testFunction($a) {
if ($a) {
return 1;
}
return 'str';
}
testFunction(null);
```
before:
after:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] troizet commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "troizet (via GitHub)" <gi...@apache.org>.
troizet commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159960150
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -608,9 +608,12 @@ private String composeType(Collection<TypeResolver> types, Type.Kind typeKind) {
if (type.isResolved()) {
QualifiedName typeName = type.getTypeName(true);
if (typeName != null) {
- if (sb.length() > 0
- && (typeKind == Type.Kind.UNION || typeKind == Type.Kind.INTERSECTION)) {
- sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ if (sb.length() > 0) {
+ if (typeKind == Type.Kind.INTERSECTION) {
+ sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ } else {
+ sb.append(" ").append(Type.Kind.UNION.getSign()).append(" "); // NOI18N
Review Comment:
Added a comment with a reason to the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 merged pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 merged PR #5779:
URL: https://github.com/apache/netbeans/pull/5779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159285092
##########
php/php.editor/test/unit/data/testfiles/completion/documentation/issueGH5355.php.testIssueGH5355_01.html:
##########
@@ -0,0 +1,13 @@
+<html><body>
+<pre>Code completion result for source line:
+$this->testMetho|d(null);
+(QueryType=COMPLETION, prefixSearch=false, caseSensitive=true)
+METHOD testMethod($a) [PUBLIC] ClassName
+</pre><h2>Documentation:</h2><div align="right"><font size=-1></font></div><b>testMethod</b><br/><br/><br />
+<h3>Parameters:</h3>
+<table cellspacing=0 style="border: 0px; width: 100%;">
+<tr><td> </td><td valign="top" style="text-aling:left; border-width: 0px;padding: 1px;padding:3px;" ><nobr></nobr></td><td valign="top" style="text-aling:left; border-width: 0px;padding: 1px;padding:3px;" ><nobr><b>$a</b></nobr></td><td valign="top" style="text-aling:left; border-width: 0px;padding: 1px;padding:3px;width:80%;" >PHPDoc not found</td></tr>
+</table>
+<h3>Returns:</h3>
+<table>
+<tr><th align="left">Type:</th><td>string | int</td></tr></table></body></html>
Review Comment:
Nitpick: Git "warns" here that the file does not end with a new line? Could we add it, please? To all newly added files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159284229
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -608,9 +608,12 @@ private String composeType(Collection<TypeResolver> types, Type.Kind typeKind) {
if (type.isResolved()) {
QualifiedName typeName = type.getTypeName(true);
if (typeName != null) {
- if (sb.length() > 0
- && (typeKind == Type.Kind.UNION || typeKind == Type.Kind.INTERSECTION)) {
- sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ if (sb.length() > 0) {
+ if (typeKind == Type.Kind.INTERSECTION) {
+ sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ } else {
+ sb.append(" ").append(Type.Kind.UNION.getSign()).append(" "); // NOI18N
Review Comment:
Personally, I would rather like to see `else if (UNION) {...` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1160008584
##########
php/php.editor/test/unit/data/testfiles/completion/documentation/issueGH5355.php.testIssueGH5355_01.html:
##########
@@ -0,0 +1,13 @@
+<html><body>
+<pre>Code completion result for source line:
+$this->testMetho|d(null);
+(QueryType=COMPLETION, prefixSearch=false, caseSensitive=true)
+METHOD testMethod($a) [PUBLIC] ClassName
+</pre><h2>Documentation:</h2><div align="right"><font size=-1></font></div><b>testMethod</b><br/><br/><br />
+<h3>Parameters:</h3>
+<table cellspacing=0 style="border: 0px; width: 100%;">
+<tr><td> </td><td valign="top" style="text-aling:left; border-width: 0px;padding: 1px;padding:3px;" ><nobr></nobr></td><td valign="top" style="text-aling:left; border-width: 0px;padding: 1px;padding:3px;" ><nobr><b>$a</b></nobr></td><td valign="top" style="text-aling:left; border-width: 0px;padding: 1px;padding:3px;width:80%;" >PHPDoc not found</td></tr>
+</table>
+<h3>Returns:</h3>
+<table>
+<tr><th align="left">Type:</th><td>string | int</td></tr></table></body></html>
Review Comment:
Great, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159284229
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -608,9 +608,12 @@ private String composeType(Collection<TypeResolver> types, Type.Kind typeKind) {
if (type.isResolved()) {
QualifiedName typeName = type.getTypeName(true);
if (typeName != null) {
- if (sb.length() > 0
- && (typeKind == Type.Kind.UNION || typeKind == Type.Kind.INTERSECTION)) {
- sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ if (sb.length() > 0) {
+ if (typeKind == Type.Kind.INTERSECTION) {
+ sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ } else {
+ sb.append(" ").append(Type.Kind.UNION.getSign()).append(" "); // NOI18N
Review Comment:
Personally, I would rather like to see `else if (UNION). {...` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] troizet commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "troizet (via GitHub)" <gi...@apache.org>.
troizet commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159938724
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -608,9 +608,12 @@ private String composeType(Collection<TypeResolver> types, Type.Kind typeKind) {
if (type.isResolved()) {
QualifiedName typeName = type.getTypeName(true);
if (typeName != null) {
- if (sb.length() > 0
- && (typeKind == Type.Kind.UNION || typeKind == Type.Kind.INTERSECTION)) {
- sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ if (sb.length() > 0) {
+ if (typeKind == Type.Kind.INTERSECTION) {
+ sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ } else {
+ sb.append(" ").append(Type.Kind.UNION.getSign()).append(" "); // NOI18N
Review Comment:
My assumption is that if more than one type is specified and it is clearly not an intersection, it is always a union. Or is it not so?
Similar logic in NavigatorScanner:
https://github.com/apache/netbeans/blob/0bcc927866938e6c7f57e1bfe8f852e983b3072f/php/php.editor/src/org/netbeans/modules/php/editor/csl/NavigatorScanner.java#L425-L446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] troizet commented on pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "troizet (via GitHub)" <gi...@apache.org>.
troizet commented on PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#issuecomment-1499959759
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] troizet commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "troizet (via GitHub)" <gi...@apache.org>.
troizet commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159959040
##########
php/php.editor/test/unit/data/testfiles/completion/documentation/issueGH5355.php:
##########
@@ -0,0 +1,24 @@
+<?php
+
Review Comment:
Done.
##########
php/php.editor/test/unit/data/testfiles/completion/documentation/issueGH5355.php.testIssueGH5355_01.html:
##########
@@ -0,0 +1,13 @@
+<html><body>
+<pre>Code completion result for source line:
+$this->testMetho|d(null);
+(QueryType=COMPLETION, prefixSearch=false, caseSensitive=true)
+METHOD testMethod($a) [PUBLIC] ClassName
+</pre><h2>Documentation:</h2><div align="right"><font size=-1></font></div><b>testMethod</b><br/><br/><br />
+<h3>Parameters:</h3>
+<table cellspacing=0 style="border: 0px; width: 100%;">
+<tr><td> </td><td valign="top" style="text-aling:left; border-width: 0px;padding: 1px;padding:3px;" ><nobr></nobr></td><td valign="top" style="text-aling:left; border-width: 0px;padding: 1px;padding:3px;" ><nobr><b>$a</b></nobr></td><td valign="top" style="text-aling:left; border-width: 0px;padding: 1px;padding:3px;width:80%;" >PHPDoc not found</td></tr>
+</table>
+<h3>Returns:</h3>
+<table>
+<tr><th align="left">Type:</th><td>string | int</td></tr></table></body></html>
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159569973
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -608,9 +608,12 @@ private String composeType(Collection<TypeResolver> types, Type.Kind typeKind) {
if (type.isResolved()) {
QualifiedName typeName = type.getTypeName(true);
if (typeName != null) {
- if (sb.length() > 0
- && (typeKind == Type.Kind.UNION || typeKind == Type.Kind.INTERSECTION)) {
- sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ if (sb.length() > 0) {
+ if (typeKind == Type.Kind.INTERSECTION) {
+ sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ } else {
+ sb.append(" ").append(Type.Kind.UNION.getSign()).append(" "); // NOI18N
Review Comment:
because of the same code... maybe...
```java
if (typeKind == Type.Kind.INTERSECTION || typeKind == Type.Kind.UNION) {
sb.append(...
} else {
// the reason
sb.append(...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159993313
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -608,9 +608,12 @@ private String composeType(Collection<TypeResolver> types, Type.Kind typeKind) {
if (type.isResolved()) {
QualifiedName typeName = type.getTypeName(true);
if (typeName != null) {
- if (sb.length() > 0
- && (typeKind == Type.Kind.UNION || typeKind == Type.Kind.INTERSECTION)) {
- sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ if (sb.length() > 0) {
+ if (typeKind == Type.Kind.INTERSECTION) {
+ sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ } else {
+ sb.append(" ").append(Type.Kind.UNION.getSign()).append(" "); // NOI18N
Review Comment:
> it is always a union. Or is it not so?
Well... not so. PHP 8.2 has DNF type. Please wait a while because I'll improve it. (I have not finished implementing it yet.)
I would do the above because we can see that the `else` part is not a case of normal union type. Your change is also no problem, of course. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159157904
##########
php/php.editor/src/org/netbeans/modules/php/editor/completion/DocRenderer.java:
##########
@@ -608,9 +608,12 @@ private String composeType(Collection<TypeResolver> types, Type.Kind typeKind) {
if (type.isResolved()) {
QualifiedName typeName = type.getTypeName(true);
if (typeName != null) {
- if (sb.length() > 0
- && (typeKind == Type.Kind.UNION || typeKind == Type.Kind.INTERSECTION)) {
- sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ if (sb.length() > 0) {
+ if (typeKind == Type.Kind.INTERSECTION) {
+ sb.append(" ").append(typeKind.getSign()).append(" "); // NOI18N
+ } else {
+ sb.append(" ").append(Type.Kind.UNION.getSign()).append(" "); // NOI18N
Review Comment:
It would be nice if you can write the reason as a comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#discussion_r1159154917
##########
php/php.editor/test/unit/data/testfiles/completion/documentation/issueGH5355.php:
##########
@@ -0,0 +1,24 @@
+<?php
+
Review Comment:
Please add the license header if possible although test files need not have it absolutely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on pull request #5779: [GH-5355] PHP: Corrects the display of the guessed return type for a function or method in the documentation
Posted by "lbownik (via GitHub)" <gi...@apache.org>.
lbownik commented on PR #5779:
URL: https://github.com/apache/netbeans/pull/5779#issuecomment-1498763080
@troizet DocRender.java could use some performance improvements.
I peeked and I eeeeked ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists