You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by jm...@apache.org on 2007/03/13 17:32:55 UTC

svn commit: r517760 - /maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml

Author: jmcconnell
Date: Tue Mar 13 09:32:52 2007
New Revision: 517760

URL: http://svn.apache.org/viewvc?view=rev&rev=517760
Log:
use of jpox.column and jpox.table to clean up the model of potential reserved key words for a wide array of databases, this is due to joakim's addition of strict model validation with modello

Modified:
    maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml

Modified: maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml
URL: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml?view=diff&rev=517760&r1=517759&r2=517760
==============================================================================
--- maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml (original)
+++ maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml Tue Mar 13 09:32:52 2007
@@ -201,7 +201,7 @@
           <type>String</type>
         </field>
         <!-- TODO: should these 3 just be queried from the builds list? -->
-        <field>
+        <field jpox.column="projectstate">
           <name>state</name>
           <version>1.1.0+</version>
           <type>int</type>
@@ -308,7 +308,7 @@
           <version>1.1.0+</version>
           <type>int</type>
         </field>
-        <field>
+        <field jpox.column="notifiertype">
           <name>type</name>
           <version>1.1.0+</version>
           <defaultValue>mail</defaultValue>
@@ -465,12 +465,12 @@
           <version>1.1.0+</version>
           <type>int</type>
         </field>
-        <field>
+        <field jpox.column="resultstate">
           <name>state</name>
           <version>1.1.0+</version>
           <type>int</type>
         </field>
-        <field>
+        <field jpox.column="resulttrigger">
           <name>trigger</name>
           <version>1.1.0+</version>
           <type>int</type>
@@ -585,12 +585,12 @@
           <version>1.1.0+</version>
           <type>String</type>
         </field>
-        <field stash.maxSize="8192">
+        <field stash.maxSize="8192" jpox.column="changecomment">
           <name>comment</name>
           <version>1.1.0+</version>
           <type>String</type>
         </field>
-        <field>
+        <field jpox.column="changedate">
           <name>date</name>
           <version>1.1.0+</version>
           <!-- TODO: Because JPOX persists as UTC and pulls back using the local time, we have to take over -->
@@ -842,7 +842,7 @@
             <type>Schedule</type>
           </association>
         </field>
-        <field>
+        <field jpox.column="buildprofile">
           <name>profile</name>
           <version>1.1.0+</version>
           <association xml.reference="true" stash.part="true" jpox.dependent="false">
@@ -886,7 +886,7 @@
           <version>1.1.0+</version>
           <type>String</type>
         </field>
-        <field>
+        <field jpox.column="scheduledelay">
           <name>delay</name>
           <description><![CDATA[
             Delay in seconds.
@@ -912,7 +912,7 @@
       </fields>
     </class>
 
-    <class>
+    <class jpox.table="profiles">
       <name>Profile</name>
       <version>1.1.0+</version>
       <fields>
@@ -974,7 +974,7 @@
           <version>1.1.0+</version>
           <type>String</type>
         </field>
-        <field>
+        <field jpox.column="installpath">
           <name>path</name>
           <version>1.1.0+</version>
           <type>String</type>
@@ -1050,7 +1050,7 @@
         Configures one method for notifying users/developers when a build breaks.
       </description>
       <fields>
-        <field>
+        <field jpox.column="notifiertype">
           <name>type</name>
           <version>1.1.0+</version>
           <defaultValue>mail</defaultValue>



Re: svn commit: r517760 - /maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml

Posted by Jesse McConnell <je...@gmail.com>.
FYI,

this change currently breaks all backward compatibility with existing
databases.  that will probably be fixed at somepoint, but for now here
it is...

The purpose of this was to remove all traces of key words that any
number of databases use in an effort to make continuum as flexible as
possible with different databases.   Brett said he was going to take
care of some kinda update dealio for it since he'll need it to update
the maven zone, but for now if your building and tracking source, this
is a breaking change for backwards compatibility.

it is just column changes and one table change here, and then the
security setup had 4 changes in its databases so a grand total of
15ish changes to the db's in continuum land.  if there anyone has big
issues with this I'll help them recover with some alter table
statements of something.

see joakims other mail on this topic on this list if you want to know more..

jesse


On 3/13/07, jmcconnell@apache.org <jm...@apache.org> wrote:
> Author: jmcconnell
> Date: Tue Mar 13 09:32:52 2007
> New Revision: 517760
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=517760
> Log:
> use of jpox.column and jpox.table to clean up the model of potential reserved key words for a wide array of databases, this is due to joakim's addition of strict model validation with modello
>
> Modified:
>     maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml
>
> Modified: maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml
> URL: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml?view=diff&rev=517760&r1=517759&r2=517760
> ==============================================================================
> --- maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml (original)
> +++ maven/continuum/trunk/continuum-model/src/main/mdo/continuum.xml Tue Mar 13 09:32:52 2007
> @@ -201,7 +201,7 @@
>            <type>String</type>
>          </field>
>          <!-- TODO: should these 3 just be queried from the builds list? -->
> -        <field>
> +        <field jpox.column="projectstate">
>            <name>state</name>
>            <version>1.1.0+</version>
>            <type>int</type>
> @@ -308,7 +308,7 @@
>            <version>1.1.0+</version>
>            <type>int</type>
>          </field>
> -        <field>
> +        <field jpox.column="notifiertype">
>            <name>type</name>
>            <version>1.1.0+</version>
>            <defaultValue>mail</defaultValue>
> @@ -465,12 +465,12 @@
>            <version>1.1.0+</version>
>            <type>int</type>
>          </field>
> -        <field>
> +        <field jpox.column="resultstate">
>            <name>state</name>
>            <version>1.1.0+</version>
>            <type>int</type>
>          </field>
> -        <field>
> +        <field jpox.column="resulttrigger">
>            <name>trigger</name>
>            <version>1.1.0+</version>
>            <type>int</type>
> @@ -585,12 +585,12 @@
>            <version>1.1.0+</version>
>            <type>String</type>
>          </field>
> -        <field stash.maxSize="8192">
> +        <field stash.maxSize="8192" jpox.column="changecomment">
>            <name>comment</name>
>            <version>1.1.0+</version>
>            <type>String</type>
>          </field>
> -        <field>
> +        <field jpox.column="changedate">
>            <name>date</name>
>            <version>1.1.0+</version>
>            <!-- TODO: Because JPOX persists as UTC and pulls back using the local time, we have to take over -->
> @@ -842,7 +842,7 @@
>              <type>Schedule</type>
>            </association>
>          </field>
> -        <field>
> +        <field jpox.column="buildprofile">
>            <name>profile</name>
>            <version>1.1.0+</version>
>            <association xml.reference="true" stash.part="true" jpox.dependent="false">
> @@ -886,7 +886,7 @@
>            <version>1.1.0+</version>
>            <type>String</type>
>          </field>
> -        <field>
> +        <field jpox.column="scheduledelay">
>            <name>delay</name>
>            <description><![CDATA[
>              Delay in seconds.
> @@ -912,7 +912,7 @@
>        </fields>
>      </class>
>
> -    <class>
> +    <class jpox.table="profiles">
>        <name>Profile</name>
>        <version>1.1.0+</version>
>        <fields>
> @@ -974,7 +974,7 @@
>            <version>1.1.0+</version>
>            <type>String</type>
>          </field>
> -        <field>
> +        <field jpox.column="installpath">
>            <name>path</name>
>            <version>1.1.0+</version>
>            <type>String</type>
> @@ -1050,7 +1050,7 @@
>          Configures one method for notifying users/developers when a build breaks.
>        </description>
>        <fields>
> -        <field>
> +        <field jpox.column="notifiertype">
>            <name>type</name>
>            <version>1.1.0+</version>
>            <defaultValue>mail</defaultValue>
>
>
>


-- 
jesse mcconnell
jesse.mcconnell@gmail.com