You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Artem Harutyunyan <ar...@mesosphere.io> on 2015/07/20 16:56:18 UTC

Review Request 36618: Fixed ROOT_CGROUPS_Tasks and ROOT_CGROUPS_Read on Ubunu 14.04.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36618/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Bugs: MESOS-3079
    https://issues.apache.org/jira/browse/MESOS-3079


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 

Diff: https://reviews.apache.org/r/36618/diff/


Testing
-------

sudo make check


Thanks,

Artem Harutyunyan


Re: Review Request 36618: Fixed ROOT_CGROUPS_Tasks and ROOT_CGROUPS_Read on Ubunu 14.04.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36618/#review92272
-----------------------------------------------------------



src/tests/cgroups_tests.cpp (line 438)
<https://reviews.apache.org/r/36618/#comment146337>

    Is invalid actually a valid hierarchy? Just want to know what's the rationale changinig this to invalid42


- Timothy Chen


On July 20, 2015, 2:56 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36618/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 2:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-3079
>     https://issues.apache.org/jira/browse/MESOS-3079
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 
> 
> Diff: https://reviews.apache.org/r/36618/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Re: Review Request 36618: Fixed ROOT_CGROUPS_Tasks and ROOT_CGROUPS_Read on Ubunu 14.04.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36618/#review92546
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 20, 2015, 2:56 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36618/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 2:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-3079
>     https://issues.apache.org/jira/browse/MESOS-3079
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 
> 
> Diff: https://reviews.apache.org/r/36618/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Re: Review Request 36618: Fixed ROOT_CGROUPS_Tasks and ROOT_CGROUPS_Read on Ubunu 14.04.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36618/#review92428
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On July 20, 2015, 2:56 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36618/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 2:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-3079
>     https://issues.apache.org/jira/browse/MESOS-3079
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb 
> 
> Diff: https://reviews.apache.org/r/36618/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>