You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by chermenin <gi...@git.apache.org> on 2016/11/15 09:34:09 UTC

[GitHub] flink pull request #2807: [FLINK-4631] Prevent some possible NPEs.

GitHub user chermenin opened a pull request:

    https://github.com/apache/flink/pull/2807

    [FLINK-4631] Prevent some possible NPEs.

    Added additional conditions in several places to check possible NPEs. This PR must completely solve [FLINK-4631](https://issues.apache.org/jira/browse/FLINK-4631).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chermenin/flink flink-4631

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2807
    
----
commit b8e8a4507de1c4a101863116b92edefc12fb14f1
Author: Aleksandr Chermenin <al...@epam.com>
Date:   2016-10-28T09:36:01Z

    [FLINK-4631] Avoided NPE in OneInputStreamTask.

commit 9a8ec134900eda502539448e8ecde42dc019fe7a
Author: Aleksandr Chermenin <al...@epam.com>
Date:   2016-11-14T09:49:48Z

    [FLINK-4631] Fixed sink functions.

commit 78176dae7168006a8430f27d9df2abc8e5a9f364
Author: Aleksandr Chermenin <al...@epam.com>
Date:   2016-11-14T14:06:21Z

    [FLINK-4631] Fixed sources and stream tasks.

commit dd70279a1a0b31f5c49c96efebed7399a77811f5
Author: Aleksandr Chermenin <al...@epam.com>
Date:   2016-11-15T09:27:09Z

    [FLINK-4631] Some streaming fixes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2807: [FLINK-4631] Prevent some possible NPEs.

Posted by chermenin <gi...@git.apache.org>.

Github user chermenin closed the pull request at:

    https://github.com/apache/flink/pull/2807


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2807: [FLINK-4631] Prevent some possible NPEs.

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2807
  
    I think we need to go through these changes one by one.
    
    In many situations, field being null indicates an error. These situations now silently do nothing, rather than at least reporting an error (even if in the form of a null pointer exception). That would make some failed programs appear succeeded.
    
    Preventing exceptions is not always correct - if a situation is invalid, it should fail with an exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---