You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "psalagnac (via GitHub)" <gi...@apache.org> on 2023/08/24 17:41:32 UTC
[GitHub] [solr] psalagnac opened a new pull request, #1864: SOLR-16879: add dedicated thread pool for expensive admin operations
psalagnac opened a new pull request, #1864:
URL: https://github.com/apache/solr/pull/1864
https://issues.apache.org/jira/browse/SOLR-16879
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
This is a simpler change compared to #1761.
# Solution
Add a dedicated thread pool in `CoreAdminHandler` for expensive admin operation. Since it has a limited number of threads, this guarantee we don't execute too many concurrent expensive operations.
# Tests
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] psalagnac commented on pull request #1864: SOLR-16879: add dedicated thread pool for expensive admin operations
Posted by "psalagnac (via GitHub)" <gi...@apache.org>.
psalagnac commented on PR #1864:
URL: https://github.com/apache/solr/pull/1864#issuecomment-1693795795
> this looks very good! much easier to follow along!
> the only minor suggestion would be to add the `isExpensive()` method to implementors of `CoreAdminAPIBase` which look like candidates for expensiveness: `BackupCoreAPI`, `RestoreCoreAPI` maybe other too but I don't really know.
Thanks for pointing this @stillalex . My understanding is the are backup/restore operations for API V2, correct?
Yes, they definitely should also be marked as expensive operations. Will change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1864: SOLR-16879: add dedicated thread pool for expensive admin operations
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on PR #1864:
URL: https://github.com/apache/solr/pull/1864#issuecomment-1693694755
this looks very good! much easier to follow along!
the only minor suggestion would be to add the `isExpensive()` method to implementors of `CoreAdminAPIBase` which look like candidates for expensiveness: `BackupCoreAPI`, `RestoreCoreAPI` maybe other too but I don't really know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] psalagnac commented on pull request #1864: SOLR-16879: add dedicated thread pool for expensive admin operations
Posted by "psalagnac (via GitHub)" <gi...@apache.org>.
psalagnac commented on PR #1864:
URL: https://github.com/apache/solr/pull/1864#issuecomment-1697060989
Thanks for you feedback. I added marked more operation as expensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] psalagnac commented on pull request #1864: SOLR-16879: add dedicated thread pool for expensive admin operations
Posted by "psalagnac (via GitHub)" <gi...@apache.org>.
psalagnac commented on PR #1864:
URL: https://github.com/apache/solr/pull/1864#issuecomment-1701018703
Suggested CHANGES.txt line:
> SOLR-16879: Limit the number of concurrent expensive core admin operations by running them in a dedicated thread pool. Backup, Restore and Split are expensive operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #1864: SOLR-16879: add dedicated thread pool for expensive admin operations
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #1864:
URL: https://github.com/apache/solr/pull/1864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org