You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/27 21:16:46 UTC

[GitHub] [incubator-nuttx] patacongo opened a new pull request #1903: Correct compilation of arch/sim/src/sim/up_wpcap.c

patacongo opened a new pull request #1903:
URL: https://github.com/apache/incubator-nuttx/pull/1903


   ## Summary
   
   The compilation was broken by a couple of recent blind, unverified changes to up_wpcap.c.  Most were introduced with commit: 8ce0ff5ce44416511be343c842c8d714687182cf with this change:
   
       diff --git a/arch/sim/src/sim/up_wpcap.c b/arch/sim/src/sim/up_wpcap.c
       index ef7b4b3a0c..a15421e80c 100644
       --- a/arch/sim/src/sim/up_wpcap.c
       +++ b/arch/sim/src/sim/up_wpcap.c
       @@ -55,6 +55,8 @@
   
        #include <netinet/in.h>
   
       +#include "up_internal.h"
       +
        /****************************************************************************
         * Pre-processor Definitions
         ****************************************************************************/
   
   up_internal.h includes:
   
        47 #  include <sys/types.h>
        48 #  include <stdbool.h>
        49 #  include <netinet/in.h>
   
   And netinet/in.h includes:
   
        46 #include <sys/types.h>
        47 #include <sys/socket.h>
        48 #include <stdint.h>
   
   Which is where the collision error is introduced since up_wpcap.c includes winsock2.h already.  There were additional problems introduced to the file by other changes:
   
   - A malformed syslog() call was added
   - Some issues with netdriver_setmacaddr()
   
   ## Impact
   
   This corrects the compilation of up_wpcap.c.  It should affect only simulator builds for simulator
   
   ## Testing
   
   I verified only that the sim:nettest configuration still builds.  The WPCAP configuration has not been verified in many years.  It would not surprise if there are not additional issues.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton merged pull request #1903: Correct compilation of arch/sim/src/sim/up_wpcap.c

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #1903:
URL: https://github.com/apache/incubator-nuttx/pull/1903


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #1903: Correct compilation of arch/sim/src/sim/up_wpcap.c

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1903:
URL: https://github.com/apache/incubator-nuttx/pull/1903#issuecomment-699720820


   I still have some issues running the all the binaries generated from sim builds in Cygwin, but this does resolve the build issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1903: Correct compilation of arch/sim/src/sim/up_wpcap.c

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1903:
URL: https://github.com/apache/incubator-nuttx/pull/1903#issuecomment-699690364


   Please ignore all of the Mixed Case identifier problems that cause the check to fail.  These are due to calls directly into the Windows networking logic which follow standard Windows CamelCase naming conventions.  There is no way around that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org