You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/06/02 20:52:04 UTC

[GitHub] [systemml] mboehm7 edited a comment on pull request #909: [SYSTEMDS-396] Distinct values estimation function

mboehm7 edited a comment on pull request #909:
URL: https://github.com/apache/systemml/pull/909#issuecomment-637798712


   LGTM - thanks for the patch @Baunsgaard. I only made some minor cleanups: (1) remove the new opcodes from Builtin.java (not actually supported as a builtin-builtin), (2) tightened the language validation (only supported over matrices, not frames/lists), (3) fixed correctness of sparse operations (count + 1 if nnz<length), (4) some minor performance improvements (data converter, redundant double-long on default hash), (5) left some additional TODOs to remind us to support large blocks beyond 16GB, and (6) reorder to github function workflows to follow alphabetical order.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org