[GitHub] [nifi] emiliosetiadarma commented on pull request #5363: NIFI-9184 Refactor shared methods in Sensitive Property Providers

[GitBox <gi...@apache.org>]

emiliosetiadarma commented on pull request #5363:
URL: https://github.com/apache/nifi/pull/5363#issuecomment-911920467


   Hey David!
   
   Thanks for continuing to build on what I worked on the past summer! Just have a few input. I was able to run the build and verify that it was working. I was wondering, documentation-wise, if we could probably put a note about uncommenting the `bootstrap-*.conf` file path in the `bootstrap.conf` for each specific cloud provider somewhere in `toolkit-guide.adoc` or `administration-guide.adoc`? 
   
   Also I was wondering if it would be better if `EncodedSensitivePropertiesProvider` extends `AbstractSensitivePropertyProvider`, that way the shared methods `getName()` and `getIdentifierKey()` would not have to be rewritten and the `getProtectionScheme()` could be implemented there.
   
   Other minor suggestions include changing naming of `EncodedSensitivePropertiesProvider` to`EncodedSensitivePropertyProvider`. And also similarly for the `ClientBasedEncodedSensitivePropertiesProvider`. That way the naming will be consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org