You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/09 12:11:40 UTC
[GitHub] [arrow-datafusion] ygf11 opened a new pull request, #4153: Add another method to collect referenced columns from an expression
ygf11 opened a new pull request, #4153:
URL: https://github.com/apache/arrow-datafusion/pull/4153
# Which issue does this PR close?
Closes #4152
# Rationale for this change
It is not easy to use [expr_to_columns](https://github.com/apache/arrow-datafusion/blob/master/datafusion/expr/src/utils.rs) to collect referenced columns from a single expression, because we need to create a new `HashSet` everytime.
Add `Expr::to_columns` to collect columns from expression.
# What changes are included in this PR?
Add a new method `Expr::to_columns`.
# Are these changes tested?
Unit test.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4153: Add another method to collect referenced columns from an expression
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4153:
URL: https://github.com/apache/arrow-datafusion/pull/4153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4153: Add another method to collect referenced columns from an expression
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4153:
URL: https://github.com/apache/arrow-datafusion/pull/4153#issuecomment-1310804437
Thanks again @ygf11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4153: Add another method to collect referenced columns from an expression
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4153:
URL: https://github.com/apache/arrow-datafusion/pull/4153#issuecomment-1310811238
Benchmark runs are scheduled for baseline = 36890b835ee8b969bbdc1c0800006b36002552af and contender = 509c82c6d624bb63531f67531195b562a241c854. 509c82c6d624bb63531f67531195b562a241c854 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3a6ad1c2d0a9469ebbe60eb0827c1e0e...22ba783004d447e5a0410a45da93f10f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/85c236326eda414d8559cb679a79ee28...85f7a4ada6044257a8c73414ca59e9a2/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/577a9e14097c42ceaa3c744d7395f6cb...a43c4fc2b151421c83656ed3d91c4c5f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b057f1ae5206408cbcafdb23425f40e5...c8b5729573c4440d8c1ab415b7ddbc4f/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org